test: cover wallet-balance and E.164 money paths#5
Open
rajarshidattapy wants to merge 1 commit into
Open
Conversation
Adds the first tests for the real money-adjacent paths that were untested: - UserInfo.Balance() — pins the /100 wallet scaling (22bc0ef), zero balance, fallback field names, and the "$%.2f" confirmation format. - e164Pattern — pins the recipient-number accept/reject boundary that gates a real, billable outbound call. Stdlib testing only, no network (both paths are pure). Adapts issue bolna-ai#3's intent to this repo — no fund-transfer/RPC/address paths exist here. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Issue 3 original wording referenced "transfer amounts" and "addresses" — that's boilerplate from a different project. This repo is a Go voice-agent CLI with no fund transfers, RPC, or crypto addresses, so I mapped the intent onto the real money paths: wallet balance display and the E.164 phone gate before a paid call. There is no amount-input path to test.
Not included (as the issue scopes out)