test: cover wallet-balance and E.164 money paths#8
Open
rajarshidattapy wants to merge 1 commit into
Open
Conversation
Author
|
hey @tanisha-byte , whenever you are free, can you look through the 4 PRs, I've put? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #1
First tests for the money-adjacent paths in
cli//tui/, which had zero coverage. A silent regression here costs real money (wrong wallet display before a billable call, or a malformed number dialed).UserInfo.Balance()internal/api/account_test.go/100wallet scaling (the 22bc0ef bug), zero balance,walletprecedence over fallback fields, unscaled fallbacks, missing/wrong-type field, and the$%.2fconfirmation-summary formate164Patterninternal/tui/callstart_test.go+) that gates a real outbound callStdlib
testingonly, table-driven to match the existingclient_test.go. Both paths are pure functions — no network, no RPC mock needed.go test ./...passes.Scope note
The issue's wording ("transfer amounts", "addresses", "RPC") is boilerplate from a different project. This repo is a Go voice-agent CLI with no fund transfers, RPC, or crypto addresses, so I mapped the intent onto its real money paths: wallet-balance display and the E.164 phone gate before a paid call. There is no amount-input path to test.
Not included (as scoped)
Add once the money paths are locked down.