Port some Hermes-3 finite volume operators (rebased) by dschwoerer · Pull Request #3335 · boutproject/BOUT-dev

dschwoerer · 2026-03-20T19:12:16Z

Rebase of #3200 on top of #3320 and #3334

Includes bug fix: ```diff - BoutReal gL = n.c - n.L; - BoutReal gR = n.R - n.c; + BoutReal gL = n.c - n.m; + BoutReal gR = n.p - n.c; ```

Co-authored-by: Peter Hill <peter.hill@york.ac.uk>

github-actions

clang-tidy made some suggestions

ZedThree · 2026-06-18T16:44:26Z

A couple of points that haven't been done:

@mrhardman pointed out some other operators that could potentially be ported, along with their checks Port some Hermes-3 finite volume operators #3200 (comment)
there's now a lot of code in the fv_ops.hxx header -- if the set of possible CellEdges implementations is closed to what's in BOUT++, it would be possible to shift stuff out of the header and provide explicit instantiations of the template functions. This would probably speed up compilation, at the cost of being harder to add new limiters

…ove-ops

github-actions

clang-tidy made some suggestions

dschwoerer · 2026-06-24T11:10:49Z

A couple of points that haven't been done:

@mrhardman pointed out some other operators that could potentially be ported, along with their checks Port some Hermes-3 finite volume operators #3200 (comment)

Sorry, I tried to follow to the comment, and from there to two PRs, but I failed to see what operators you would like to add here?
Do you also want to add them to these tests, or do you want to also port some of the non-orthogonal mesh tests to BOUT++?
I am not objecting to that, but could this be a separate PR?
This one already "blocks" #3392 and #3405.

there's now a lot of code in the fv_ops.hxx header -- if the set of possible CellEdges implementations is closed to what's in BOUT++, it would be possible to shift stuff out of the header and provide explicit instantiations of the template functions. This would probably speed up compilation, at the cost of being harder to add new limiters

✔️ done in #3405

Compile finite volume implementation only once

github-actions

clang-tidy made some suggestions

…ove-ops

Preview: Use cell area and volume for finite volume code

dschwoerer · 2026-06-30T07:07:08Z

I found some MMS tests in hermes-3 that fail with this PR. I will have look whether they can be moved to BOUT++ and fixed.

We need to ensure that fv_ops_impl.hxx is never parsed before fv_ops.hxx, as fv_ops.hxx provides default arguments, which is forbiddef for a redeclaration. To ensure this, fv_ops.hxx is included in fv_ops_impl.hxx, so that fv_ops_impl.hxx can be included and fv_ops.hxx can appear afterwards without causing an error.

dschwoerer · 2026-07-02T10:08:10Z

The MMS tests should be fixed by f893f3d

CI run here: https://github.com/boutproject/hermes-3/actions/runs/28581902968

github-actions

clang-tidy made some suggestions

Was testing _cell_volume.has_value() rather than _cell_area_zlow.has_value(). Added regression test.

Field-aligned operation returns a flow diagnostic, but this is not currently done for FCI. Set to zero and document behavior.

Short descriptions of the ported operators, SuperBee slope limiter, and metric derived quantity caching.

bendudson

Thanks @dschwoerer !

ZedThree and others added 15 commits March 11, 2026 12:48

Port FV::Div_par_mod from Hermes-3

5c6e3a7

Port FV::Div_par_fvv from Hermes-3

3059d12

Port Div_par_K_Grad_par_mod from Hermes-3

60f1946

Add MMS tests for finite volume operators

f53b8f3

Add tests for all FV slope limiters

207802f

Port Superbee finite volume limiter from Hermes-3

a230642

Includes bug fix: ```diff - BoutReal gL = n.c - n.L; - BoutReal gR = n.R - n.c; + BoutReal gL = n.c - n.m; + BoutReal gR = n.p - n.c; ```

Fix clang-tidy warnings for fv_ops

30dc670

Move check up

fcfe963

Ensure FCI path is always used for FCI

b209a5a

FV_div_par_fvv seems to be reduced order due to slope limiting character

e0480fc

Add doc to option

7ffc7fa

Co-authored-by: Peter Hill <peter.hill@york.ac.uk>

Merge remote-tracking branch 'origin/hermitespline' into HEAD

aa8e5d4

Merge branch 'f3dparallel' into move-ops

2d922ec

Merge branch 'f3dparallel' into move-ops

1aedd28

Merge branch 'f3dparallel' into move-ops

04d3ab3

dschwoerer mentioned this pull request Mar 20, 2026

Port some Hermes-3 finite volume operators #3200

Closed

github-actions Bot reviewed Mar 20, 2026

View reviewed changes

dschwoerer added 4 commits March 20, 2026 21:01

prek fixes

b2a7383

Merge branch 'next' of github.com:boutproject/BOUT-dev into move-ops

6400a1d

Remove unused header

24c9992

Merge branch 'cell_area_volume' into move-ops-area

b3ccacb

dschwoerer mentioned this pull request Jun 16, 2026

Preview: Use cell area and volume for finite volume code #3392

Merged

bshanahan self-assigned this Jun 16, 2026

dschwoerer added 4 commits June 17, 2026 10:47

Use cell area and volumes for div_par_mod

639808c

Use cell area and volumes for Div_par_fvv

5a2a3dc

Use cell area and volumes for Div_par

820e221

Also fill the boundaries to the extend possible

3b0117e

Merge branch 'next' of https://github.com/boutproject/BOUT-dev into m…

8aeea3d

…ove-ops

github-actions Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread src/mesh/difops.cxx Outdated

Comment thread src/mesh/difops.cxx

Comment thread tests/MMS/spatial/finite-volume/fv_mms.cxx

dschwoerer added 3 commits June 24, 2026 12:46

Add comments about explicit instantiation

b98954f

Do not return from critical areas

e68d165

Add missing header

a995360

dschwoerer and others added 4 commits June 24, 2026 13:12

Remove TRACE

5284cc1

Move critical section to compute functions

1672208

Add DDY template for expression

b89867d

Merge pull request #3405 from boutproject/move-ops-impl

e00a0a0

Compile finite volume implementation only once

github-actions Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread include/bout/fv_ops.hxx

Comment thread include/bout/fv_ops.hxx Outdated

dschwoerer added 5 commits June 26, 2026 10:30

Merge branch 'next' of https://github.com/boutproject/BOUT-dev into m…

d914903

…ove-ops

Merge branch 'move-ops' into move-ops-area

586c06b

Add missing used header

26876b7

Merge pull request #3392 from boutproject/move-ops-area

30f42fc

Preview: Use cell area and volume for finite volume code

Remove unused headers

bf5f01d

dschwoerer marked this pull request as draft June 30, 2026 07:07

dschwoerer added 2 commits July 2, 2026 11:18

Fix nonorthogonal MMS test for hermes-3

f893f3d

dschwoerer marked this pull request as ready for review July 2, 2026 10:08

github-actions Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread include/bout/fv_ops_impl.hxx

This was referenced Jul 2, 2026

Fixups for compiling with 3D metrics boutproject/hermes-3#586

Merged

Fix lots of clang-tidy issues in fv_ops #3007

Open

bendudson added 3 commits July 4, 2026 08:54

Coordinates::_compute_cell_area_z check _compute_cell_area_z

0b187d9

Was testing _cell_volume.has_value() rather than _cell_area_zlow.has_value(). Added regression test.

FV ops: Document diagnostics for FCI args

2c41fca

Field-aligned operation returns a flow diagnostic, but this is not currently done for FCI. Set to zero and document behavior.

Documentation of FV operators and metric caching

8fb81ad

Short descriptions of the ported operators, SuperBee slope limiter, and metric derived quantity caching.

bendudson approved these changes Jul 4, 2026

View reviewed changes

dschwoerer mentioned this pull request Jul 6, 2026

Move more FV ops from hermes-3 to BOUT++ #3419

Open

dschwoerer merged commit e5c3a61 into next Jul 6, 2026
23 checks passed

dschwoerer deleted the move-ops branch July 6, 2026 12:33

Uh oh!

Conversation

dschwoerer commented Mar 20, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZedThree commented Jun 18, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dschwoerer commented Jun 24, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dschwoerer commented Jun 30, 2026

Uh oh!

dschwoerer commented Jul 2, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bendudson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants