Skip to content

Cleanup YBoundary#3416

Merged
ZedThree merged 35 commits into
nextfrom
yboundary-cleanup
Jul 8, 2026
Merged

Cleanup YBoundary#3416
ZedThree merged 35 commits into
nextfrom
yboundary-cleanup

Conversation

@dschwoerer

Copy link
Copy Markdown
Contributor

Follow up on #3308

  • Removes duplicate implementation for FCI and FA. They where part of the initial design. The new design uses a unified CRTP implementation, that FCI, FA and X-direction share.
  • Adds units tests
  • Switches yboundary to use unified implementation.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread include/bout/boundary_common.hxx
Comment thread include/bout/boundary_common.hxx Outdated
Comment thread include/bout/boundary_common.hxx Outdated
Comment thread include/bout/boundary_iterator.hxx
Comment thread include/bout/boundary_region_iter.hxx
Comment thread include/bout/yboundary_regions.hxx
Comment thread src/mesh/boundary_factory.cxx Outdated
Comment thread src/mesh/boundary_factory.cxx Outdated
Comment thread src/mesh/boundary_factory.cxx Outdated
Comment thread src/mesh/impls/bout/boutmesh.cxx Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread include/bout/boundary_common.hxx
Comment thread include/bout/boundary_common.hxx
Comment thread src/mesh/boundary_factory.cxx Outdated
Comment thread src/mesh/boundary_factory.cxx Outdated
@dschwoerer dschwoerer requested a review from ZedThree July 6, 2026 12:33

@ZedThree ZedThree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dschwoerer! I really like that we're finally getting rid of some raw pointers in Mesh! I feel like we probably have more dynamic_casts than strictly necessary, but I haven't looked into it too hard

@ZedThree ZedThree merged commit a8d6f70 into next Jul 8, 2026
23 checks passed
@ZedThree ZedThree deleted the yboundary-cleanup branch July 8, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants