div_ops: Compile with METRIC_3D#577
Open
bendudson wants to merge 52 commits into
Open
Conversation
Modify Div_par_fvv and Div_par_fvv_heating so that they compile with 3D metrics.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 56.92% 57.17% +0.24%
==========================================
Files 97 96 -1
Lines 10092 9902 -190
Branches 1462 1438 -24
==========================================
- Hits 5745 5661 -84
+ Misses 3757 3658 -99
+ Partials 590 583 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Dataset.hermes.extract_[12]_tokamak_geometry() calls now result in an
error:
```
Traceback (most recent call last):
File "/home/runner/work/hermes-3/hermes-3/build/tests/integrated/2D-recycling/runtest", line 144, in <module>
ds = ds.hermes.extract_2d_tokamak_geometry()
File "/home/runner/.local/lib/python3.10/site-packages/xhermes/accessors.py", line 172, in extract_2d_tokamak_geometry
raise Exception(
Exception: extract_2d_tokamak_geometry was called twice! Note: this is now done automatically upon loading
```
bshanahan
reviewed
Jun 11, 2026
bshanahan
left a comment
bshanahan
left a comment
Collaborator
There was a problem hiding this comment.
Looks OK to me -- don't think the test failures are related to this PR.
The interpolation method for the cell faces was modified, resulting in slightly different results.
Fixups for compiling with 3D metrics
dschwoerer
force-pushed
the
compile-3dmetric
branch
from
July 6, 2026 13:14
2edba35 to
a18fa1f
Compare
dschwoerer
approved these changes
Jul 8, 2026
Collaborator
|
The testing coverage is not really helpful, as so far 3D metrics only enables compiling. There will be more tests coming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify Div_par_fvv and Div_par_fvv_heating so that they compile with 3D metrics.
Maybe helps address issue #573