Conversation
…self-reported role Policy call while testing the audit: "only people who can be pulled out of RePORTER are PIs." Verified against the KG -- of 24 addresses on pi@ that were queried, 23 are Co-Investigator and only one is genuinely PI-level. They are not intruders: groupsForRole treats co-investigator as PI-level, so the rule itself was wider than the policy. The audit now derives pi@ entitlement from grant_investigators (contact_pi/co_pi/mpi/PI), which is the NIH-RePORTER-derived roster, and ignores investigators.role entirely for this purpose -- 25 members self-report a PI-ish title with no PI roster row at all, and roster 'co-investigator' does not qualify either. Expected pi@ membership: 98 -> 74. It also now reports EXTRA members by ADDRESS per group (previously only a count), because that is the list an admin has to act on. Repair still only ADDS -- removals stay a deliberate manual action, deliberately, since removing people from a mailing list is outward-facing. NOTE: the agent's groupsForRole and the KG sync-member-groups still assign pi@ from the self-reported role, so new co-investigators will keep being added until those follow this rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…self-reported role
Policy call while testing the audit: "only people who can be pulled out of RePORTER are PIs." Verified against the KG -- of 24 addresses on pi@ that were queried, 23 are Co-Investigator and only one is genuinely PI-level. They are not intruders: groupsForRole treats co-investigator as PI-level, so the rule itself was wider than the policy.
The audit now derives pi@ entitlement from grant_investigators (contact_pi/co_pi/mpi/PI), which is the NIH-RePORTER-derived roster, and ignores investigators.role entirely for this purpose -- 25 members self-report a PI-ish title with no PI roster row at all, and roster 'co-investigator' does not qualify either. Expected pi@ membership: 98 -> 74.
It also now reports EXTRA members by ADDRESS per group (previously only a count), because that is the list an admin has to act on. Repair still only ADDS -- removals stay a deliberate manual action, deliberately, since removing people from a mailing list is outward-facing.
NOTE: the agent's groupsForRole and the KG sync-member-groups still assign pi@ from the self-reported role, so new co-investigators will keep being added until those follow this rule.