Skip to content

feature: send payPalCampaigns in customer session GraphQL requests - #1649

Merged
saralvasquez merged 13 commits into
braintree:paypal-campaigns-featurefrom
santugowda:paypal-campaigns-si-apis
Aug 4, 2026
Merged

feature: send payPalCampaigns in customer session GraphQL requests#1649
saralvasquez merged 13 commits into
braintree:paypal-campaigns-featurefrom
santugowda:paypal-campaigns-si-apis

Conversation

@santugowda

@santugowda santugowda commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

  • Wire the optional payPalCampaigns list into the create session, update session, and generate recommendations GraphQL requests — sent as paypalCampaigns in variables.input.
  • Adds unit tests asserting each request includes paypalCampaigns (camelCase) with the correct [{ id }] shape.

Completes Shopper Insights v2 campaign support. Builds on #1647 (model + request builder) — this PR must merge after #1647. Backend is merged (cosmos-apps #10542). The v2 surface is @ExperimentalBetaApi.

Steps to test: on the Shopper Insights V2 demo screen, run Create/Update Customer Session and Get Recommendations; confirm each GraphQL request body includes "paypalCampaigns": [{ "id": "..." }] under variables.input.

AI Usage

Which AI Agent Was Used?

  • Copilot
  • Claude
  • Other (Type Name Here)

How was AI used?
Code generation for the API wiring and unit tests; research to confirm the GraphQL field name and placement.

Estimated AI Code Contribution

  • less than 30%
  • 30 - 60%
  • 60 - 100%

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

  • santugowda

Inner Source Process

Internal to PayPal contributors should fill out this section. All others can delete.

PR should follow these steps before codeowners review will begin:

  1. Comment /inner source on this PR — this will automatically add the inner source and tech lead review required labels. Open the PR in a draft state.
  2. PR should be reviewed by and approved by your team's technical lead, we do not allow LGTM reviews, there should be comments and feedback provided on all PR reviews
  3. Once the above steps are completed, comment /ready on this PR — this will automatically remove the tech lead review required label. Move the PR to ready to review.
  4. PR comments must be addressed within 24 hours, if you are unable to address within this timeframe, move the PR back to a draft state so our team knows not to review

Inner Source Checklist

  • Added all labels to the PR
  • Provide steps to test the flows changed, if applicable in the summary
  • Demo video of the functionality, if applicable
  • All upstream dependencies are merged in and this PR can be released at any time; PRs should not be opened until this is true
  • Unit tests and builds have been run locally and pass/compile as expected

Add PayPalCampaign model and an optional payPalCampaigns list on. CustomerSessionRequest, and build the paypal_campaigns JSON array in CustomerSessionRequestBuilder.
@santugowda

Copy link
Copy Markdown
Contributor Author

/inner source

@github-actions github-actions Bot added inner source This PR is internal to PP but external to the mobile SDK team tech lead review required labels Jul 15, 2026

@anibalb2500 anibalb2500 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks but looks good to me otherwise.

@santugowda
santugowda force-pushed the paypal-campaigns-si-apis branch from e14b572 to 3ce9ab1 Compare July 17, 2026 15:53
@anibalb2500

Copy link
Copy Markdown
Contributor

LGTM

@santugowda
santugowda marked this pull request as ready for review July 17, 2026 16:06
@santugowda
santugowda requested a review from a team July 17, 2026 16:06
@santugowda
santugowda requested a review from a team as a code owner July 17, 2026 16:06
@santugowda
santugowda force-pushed the paypal-campaigns-si-apis branch from 6f8c01d to 2c4212c Compare July 21, 2026 19:09
@santugowda
santugowda changed the base branch from main to paypal-campaigns-feature July 21, 2026 19:15
@santugowda

Copy link
Copy Markdown
Contributor Author

/ready

@saralvasquez saralvasquez changed the title feature(ShopperInsights): send payPalCampaigns in customer session GraphQL requests feature: send payPalCampaigns in customer session GraphQL requests Jul 28, 2026

@jaxdesmarais jaxdesmarais left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot duplicated in this PR with the other one. Which one should be open/prioritized?

@santugowda

Copy link
Copy Markdown
Contributor Author

There is a lot duplicated in this PR with the other one. Which one should be open/prioritized?

@jaxdesmarais /@saralvasquez This one is related to ShopperInsights - needs to be merged after #1647

@jaxdesmarais

Copy link
Copy Markdown
Contributor

Marking as do not review/merge as it is dependent on another PR. Once the other PR is merged in we will review this. In the future, dependent PRs should not be opened until the parent PR is merged.

@santugowda

Copy link
Copy Markdown
Contributor Author

The parent PR i.e. #1647 got merged to the feature branch, this PR is ready for review
cc: @jaxdesmarais , @saralvasquez

Comment thread CHANGELOG.md Outdated
…nreleased

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jaxdesmarais

Copy link
Copy Markdown
Contributor

@santugowda will there be a follow up PR for the demo app? I see we added this to the demo app on iOS but not Android.

@santugowda

Copy link
Copy Markdown
Contributor Author

@santugowda will there be a follow up PR for the demo app? I see we added this to the demo app on iOS but not Android.

Yes, I will have new PR for demo app changes.
Trying to keep the changes minimal to get it reviewed and merged asap.

@saralvasquez saralvasquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@santugowda

santugowda commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Created a new PR to update the demo app #1661 (getting it reviewed internally). Can we merge this in the meantime.
cc: @jaxdesmarais

@saralvasquez
saralvasquez merged commit 1c21794 into braintree:paypal-campaigns-feature Aug 4, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inner source This PR is internal to PP but external to the mobile SDK team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants