feature: send payPalCampaigns in customer session GraphQL requests - #1649
Conversation
Add PayPalCampaign model and an optional payPalCampaigns list on. CustomerSessionRequest, and build the paypal_campaigns JSON array in CustomerSessionRequestBuilder.
|
/inner source |
anibalb2500
left a comment
There was a problem hiding this comment.
Small nitpicks but looks good to me otherwise.
e14b572 to
3ce9ab1
Compare
|
LGTM |
…aphQL requests Wire the optional payPalCampaigns list into the create session, update session, and generate recommendations GraphQL requests as paypalCampaigns in variables.input.
6f8c01d to
2c4212c
Compare
|
/ready |
…ayPalCampaigns per interface spec
jaxdesmarais
left a comment
There was a problem hiding this comment.
There is a lot duplicated in this PR with the other one. Which one should be open/prioritized?
@jaxdesmarais /@saralvasquez This one is related to ShopperInsights - needs to be merged after #1647 |
|
Marking as do not review/merge as it is dependent on another PR. Once the other PR is merged in we will review this. In the future, dependent PRs should not be opened until the parent PR is merged. |
|
The parent PR i.e. #1647 got merged to the feature branch, this PR is ready for review |
…nreleased Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@santugowda will there be a follow up PR for the demo app? I see we added this to the demo app on iOS but not Android. |
Yes, I will have new PR for demo app changes. |
|
Created a new PR to update the demo app #1661 (getting it reviewed internally). Can we merge this in the meantime. |
1c21794
into
braintree:paypal-campaigns-feature
Summary of changes
payPalCampaignslist into the create session, update session, and generate recommendations GraphQL requests — sent aspaypalCampaignsinvariables.input.paypalCampaigns(camelCase) with the correct[{ id }]shape.Completes Shopper Insights v2 campaign support. Builds on #1647 (model + request builder) — this PR must merge after #1647. Backend is merged (cosmos-apps #10542). The v2 surface is
@ExperimentalBetaApi.Steps to test: on the Shopper Insights V2 demo screen, run Create/Update Customer Session and Get Recommendations; confirm each GraphQL request body includes
"paypalCampaigns": [{ "id": "..." }]undervariables.input.AI Usage
Which AI Agent Was Used?
How was AI used?
Code generation for the API wiring and unit tests; research to confirm the GraphQL field name and placement.
Estimated AI Code Contribution
Checklist
Authors
Inner Source Process
Internal to PayPal contributors should fill out this section. All others can delete.
PR should follow these steps before codeowners review will begin:
/inner sourceon this PR — this will automatically add theinner sourceandtech lead review requiredlabels. Open the PR in a draft state./readyon this PR — this will automatically remove thetech lead review requiredlabel. Move the PR to ready to review.Inner Source Checklist