Cross-chain: receive - #238
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dangeross
force-pushed
the
savage-cross-chain-receive
branch
from
June 23, 2026 16:27
f1a39c4 to
b8ef04c
Compare
dangeross
force-pushed
the
savage-cross-chain-receive
branch
from
June 24, 2026 08:24
b8ef04c to
e7f1402
Compare
dangeross
force-pushed
the
savage-cross-chain-receive
branch
from
July 13, 2026 10:37
63e3ae6 to
4e8a9c9
Compare
dangeross
force-pushed
the
savage-cross-chain-receive
branch
from
July 15, 2026 09:45
4e8a9c9 to
c33357a
Compare
dangeross
force-pushed
the
savage-cross-chain-receive
branch
from
July 20, 2026 12:47
c33357a to
5b19fca
Compare
dangeross
force-pushed
the
savage-cross-chain-receive
branch
from
September 1, 2026 12:34
5b19fca to
8cf7e06
Compare
dangeross
force-pushed
the
savage-cross-chain-receive
branch
2 times, most recently
from
September 3, 2026 07:21
6f3a432 to
66221fc
Compare
dangeross
force-pushed
the
savage-cross-chain-receive
branch
from
September 9, 2026 11:59
66221fc to
fb2b6a0
Compare
dangeross
marked this pull request as ready for review
September 9, 2026 12:17
The USD tab pinned its container at 500px so the sheet opened at the result step's height on every step. A short step (amount, coin picker) was padded out with dead space below its buttons, and the sheet never re-adjusted between steps. Drop the fixed height and let each step size itself: BottomSheetCard already observes content and re-snaps. The selection lists keep their Back/Continue row on screen through their own viewport cap, which is the path the send flow uses, so the `fill` prop the fixed height needed goes away. Top padding now matches the other tabs. Every USD step starts at pt-6 (the Bitcoin tab's step padding); before, the coin and network steps had none and the result step had pt-4.
StepContainer floors its content at 280px. The amount step is shorter than that, so it kept a band of dead space under Continue even after the sheet stopped being pinned at 500px. Render the USD tab outside StepContainer, the way the cross-chain send flow already does, so every step sizes to its own content and the sheet tracks it. The loading step switches to the send flow's py-12 for the same reason: no fixed height left to center against.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a USD tab to the Receive panel so someone can pay you a stablecoin from another chain and have it land in your Spark wallet, as BTC or USDB. This mirrors the cross-chain send flow that already exists.
Gated behind a new dev-only "Receive USD" toggle in Settings.
The flow
Enter a dollar amount, pick the coin and network you want to be paid in (a step is skipped when there is only one option), then show a QR of the deposit address with the amount to send and what will arrive. The SDK links the incoming payment once the sender deposits.
Payment amount fix
Amounts are now shown using the decimals of the asset they are actually in. Before, a transfer delivered on a chain with different precision could read wildly wrong: a $3 transfer displayed as $3 trillion. This affects the payments list, payment details, and the celebration screen, not just cross-chain receive.