Add test coverage for pre-1970 dates - #215
Open
st3fan wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 50.60% 53.00% +2.40%
==========================================
Files 17 17
Lines 1984 2079 +95
==========================================
+ Hits 1004 1102 +98
+ Misses 980 977 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briansmith
reviewed
Apr 21, 2021
| assert_eq!( | ||
| Err(Error::BadDerTime), | ||
| time_from_ymdhms_utc(UNIX_EPOCH_YEAR - 1, 1, 1, 0, 0, 0) | ||
| ); |
Owner
There was a problem hiding this comment.
This seems OK to me, but I'd also like to see test cases for the very edge cases: the moment before the first of 1970 and exactly 1970.
Author
There was a problem hiding this comment.
I changed the tests to cover:
- 1969-12-31 00:00:00
- 1969-12-31 23:59:59
- 1970-01-01 00:00:00
- 1970-01-01 00:00:01
- 1971-01-01 00:00:00
This would catch off by one errors in date calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds some extra tests for
calendar.rsfor the code paths that check for pre-1970 dates. I noticed that the tests only looked at the happy path so I added some that make sure an Err is returned when expected.