Repository navigation
Conversation
A ZIP can point its central directory, local headers, or compressed data outside the mapped file. Validate each range before reading it so a malformed game or state archive cannot crash the decoder.
A short state can reach System::unserialize with too little data for its header. Malformed previews can also be copied as full images. Check file section lengths, decoded preview size, and serializer capacity before consuming state data.
Contributor
|
Thanks for looking into this. I'm curious - did you run into this problem yourself and try to solve it, or were you just in the mood to look for missing bounds-checks? |
Author
Sometimes you just get in that mood man. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode::ZIP::open follows central-directory and local-file offsets without
checking that they stay inside the mapped archive. A malformed game or state
ZIP can crash bsnes while it parses or extracts an entry. Validate the
directory, local header, and payload ranges before using them.
Program::loadStateData accepts a short .bst file that can reach
System::unserialize without a complete header. StateManager::updateSelection
can also copy a truncated preview as a full image. Validate the state
sections and preview size, then require the serializer capacity to match
the declared system state size before deserializing.