Repository navigation
Conversation
Cx4 scale and rotate commands trusted ROM-controlled dimensions when clearing and rendering into the 3 KiB HLE RAM buffer. Large values could overwrite memory beyond the global Cx4 object. Reject layouts that exceed RAM, validate the disintegrate source and output ranges, and stop object table reads at the end of Cx4 RAM. Use wider intermediates for the related coordinate calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cx4::C4DoScaleRotate()used dimensions written by emulated software to calculate a clear size and direct indexes into the 3 KiB HLE RAM buffer without validating the resulting layout. A crafted Cx4 ROM could makeop00_07write beyond the global Cx4 object, potentially crashing or corrupting the emulator process.Reject scale and rotate layouts that exceed Cx4 RAM, and validate the source and output ranges used by the related
op00_0bdisintegrate command. Stopop00_00object table reads at the end of RAM and use wider intermediates for the affected coordinate calculations.