Skip to content

Update repositories.bzl and example versions#143

Merged
pkwarren merged 1 commit intomainfrom
pkw/update-repositories
Apr 27, 2026
Merged

Update repositories.bzl and example versions#143
pkwarren merged 1 commit intomainfrom
pkw/update-repositories

Conversation

@pkwarren
Copy link
Copy Markdown
Member

A previous release bumped go.mod dependencies and a few Bazel dependencies (rules_go, gazelle). We should ensure these updates are reflected across repositories.bzl and the examples.

A previous release bumped go.mod dependencies and a few Bazel
dependencies (rules_go, gazelle). We should ensure these updates are
reflected across repositories.bzl and the examples.
Comment thread examples/echo/proto/echo/v1/BUILD.bazel
Copy link
Copy Markdown

@jonbodner-buf jonbodner-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

Comment thread buf/internal/breaking.bzl
load("@rules_proto//proto:defs.bzl", "ProtoInfo")
load(":plugin.bzl", "protoc_plugin_test")
load("@rules_proto//proto:proto_common.bzl", proto_toolchains = "toolchains")
load(":plugin.bzl", "protoc_plugin_test")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran make format which made these changes. I'm accumulating all of this stuff to automate in a CI check.

Comment thread examples/echo/proto/echo/v1/BUILD.bazel

bazel_dep(name = "rules_buf", version = "0.0.0", dev_dependency = True)
bazel_dep(name = "gazelle", version = "0.36.0", dev_dependency = True)
bazel_dep(name = "gazelle", version = "0.40.0", dev_dependency = True)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to keep in sync w/ the rules_buf dependencies. This worked but led to warnings at runtime.

@pkwarren pkwarren merged commit 104fc5e into main Apr 27, 2026
8 checks passed
@pkwarren pkwarren deleted the pkw/update-repositories branch April 27, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants