Skip to content

Platform Spec is ambiguous about usage of extender #389

Description

@c0d1ngm0nk3y

We want to adapt our platform to make use of extensions, but the usage of the extender is not that clear.

If using extender, the platform MUST execute extender in either or both of: the build environment, the run environment

In addition with this comment, it seems like the extender must be called from the build image when called with --build and from the run image when called with --run. But the either or both in the spec is a bit confusing.

  • If so - what is the background for calling the extender (run) in the context of the run image? Both detect and generate are already executed and "only" executing kaniko is still missing and the image should not make any difference there, right?

Background of this question is that it would complicate things quite a bit, e.g.:

  • Calling it from within the creator, see issue
  • Implementing a platform from within a container, e.g. cnbBuild

The usage of the extender is not clearly specified, imho.

  • extender (build) MUST be called regardless of any extension present since it includes the build
  • extender (run) MUST NOT be called if there is no run extension detected. At least judging by the reference implementation. Wouldn't it be easier if the extender (run) can always be called and might do nothing?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions