Conversation
Author
|
You are passing Null Value to source_image['ImageId'] --> This wont work. Did you try to execute the script ? |
|
Hello Bhasatish, This script does work, the default parameters return amazon public AMI's and works dandy. I have done a PR: #2 which will handle empty exeception |
Shinerrs
suggested changes
Aug 16, 2018
Shinerrs
left a comment
Shinerrs
left a comment
There was a problem hiding this comment.
This is not a PR worth merging, its just comments to make your case. This should be in a issue not in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script is incomplete.