fix(gemspec): add rake to development dependencies#4
Merged
Conversation
The rubygems/release-gem@v1 action (used by our publish workflow for OIDC
trusted publishing) runs `bundle exec rake release` internally. Rakefile
already loads bundler/gem_tasks — which provides the `release` task — but
the rake gem itself was not declared as a development dependency, so
`bundle install` did not pull it into the bundle. Result:
can't find executable rake for gem rake.
rake is not currently included in the bundle
Adding rake ~> 13.0 as a development dependency fixes this and also
enables local devs to run `bundle exec rake spec` / `rake rubocop`
without a separate gem install.
Verified complete chain for `bundle exec rake release` on CI:
- rake dev dep: NOW PRESENT
- Rakefile: exists, `require 'bundler/gem_tasks'` ✓
- s.version = Bybit::VERSION: pulls from lib/bybit/version.rb ✓
- rubygems.org trusted publisher: configured for
bybit-exchange/bybit.ruby.api + publish.yml, no environment ✓
- Ruby 3.3.5 + bundler 2.5.x: aligned with .ruby-version ✓
- Git identity + OIDC creds: set up by release-gem action before rake ✓
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rubygems/release-gem@v1 action (used by our publish workflow for OIDC trusted publishing) runs
bundle exec rake releaseinternally. Rakefile already loads bundler/gem_tasks — which provides thereleasetask — but the rake gem itself was not declared as a development dependency, sobundle installdid not pull it into the bundle. Result:Adding rake ~> 13.0 as a development dependency fixes this and also enables local devs to run
bundle exec rake spec/rake rubocopwithout a separate gem install.Verified complete chain for
bundle exec rake releaseon CI:require 'bundler/gem_tasks'✓