Set anti-fee-sniping locktime (exact-tip) on bitcoin sends#3385
Open
bc1cindy wants to merge 1 commit into
Open
Set anti-fee-sniping locktime (exact-tip) on bitcoin sends#3385bc1cindy wants to merge 1 commit into
bc1cindy wants to merge 1 commit into
Conversation
Current tip (exact-tip) via shared helper, wired into normal sends (path A) and payjoin/PSBT (path B). 0 when unsynced. Converges with the exact-tip cluster (payjoin-cli, ldk-node, Bull Bitcoin) and skips the ~10% backdate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cake sets
nLockTime = 0on all BTC txs — no anti-fee-sniping, and a unique fingerprint (payjoins especially).Set it to the current tip (exact-tip) via a shared helper, wired into both locktime-defaulting paths:
BitcoinTransactionBuilder(normal sends) andPSBTTransactionBuild/PsbtV2viasetGlobalFallbackLocktime(payjoin originalPsbt).0when unsynced.Converges with the exact-tip cluster (payjoin-cli, ldk-node, Bull Bitcoin) and Core's default for externally-constructed txs, and takes Cake off the
0fingerprint. Skips the ~10% backdate Core/Electrum apply for delayed-broadcast privacy — a contested, declining signal that doesn't apply in payjoin.depends on cake-tech/bitcoin_base#13 · closes #3361