check if it will affect the performance of wallet loading time and wa…#3393
Open
OmarHatem28 wants to merge 2 commits into
Open
check if it will affect the performance of wallet loading time and wa…#3393OmarHatem28 wants to merge 2 commits into
OmarHatem28 wants to merge 2 commits into
Conversation
…llet usage in general
MrCyjaneK
reviewed
Jul 11, 2026
| walletInfo.setUsedAddresses(usedAddresses.toList()); | ||
| walletInfo.setHiddenAddresses(hiddenAddresses.toList()); | ||
| walletInfo.setManualAddresses(manualAddresses.toList()); | ||
| // TODO: check if it will affect the performance of each wallet |
Collaborator
There was a problem hiding this comment.
Performance aside we may throw errors when things aren't getting saved in db or cause display issues. definitely should be either awaited or not done at all
Contributor
Author
There was a problem hiding this comment.
yeah this is why I added the await because it indeed was throwing some errors, but not sure how frequent this save function is called, but I assume a lot, so we might need to make that in a different thread or so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llet usage in general
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist