fix android CI#3395
Conversation
|
probably will get fixed by #3390 |
|
Yes I know but it changes the ledger dependency - so we need to run full tests on ledger on this build before merging as the git hash differs. |
|
Git hash that I would be more supportive of merging now is 46d146db5d3d79b1c14051c477b9ddef9e4dc287 as that's the upstream merge commit. Two commits on top shouldn't affect anything but since this is a native plugin and it touches native code in android/ dir upstream I wouldn't just assume it does nothing (and definitely wouldn't be for merging it as just CI fix) |
Yeah, we can always run the tests as needed, however the difference between the old hash and the new hash is a changelog file. By the way, the old hash dad482c8 (konstantinullrich/ledger-usb-plus) was force-pushed on upstream and that's what caused the failure, this simply replaces it with minimal difference here's exactly what the hash change is |
|
oh I had a wrong tab open and check diff against the actual upstream... Force push on main branch.. |
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist