Skip to content

fix android CI#3395

Merged
MrCyjaneK merged 1 commit into
devfrom
fix-android-ci
Jul 11, 2026
Merged

fix android CI#3395
MrCyjaneK merged 1 commit into
devfrom
fix-android-ci

Conversation

@Blazebrain

Copy link
Copy Markdown
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

@MrCyjaneK

Copy link
Copy Markdown
Collaborator

probably will get fixed by #3390

@Blazebrain

Copy link
Copy Markdown
Contributor Author

probably will get fixed by #3390

This is to get the CI back up and running as its slowing down tests with it failing. #3390 is bringing in all the fixes ledger related.

We don't have to wait for it (if its not ready for merge), as the CI failing is delaying other builds

@Blazebrain Blazebrain self-assigned this Jul 11, 2026
@Blazebrain Blazebrain marked this pull request as ready for review July 11, 2026 21:44
@MrCyjaneK

Copy link
Copy Markdown
Collaborator

Yes I know but it changes the ledger dependency - so we need to run full tests on ledger on this build before merging as the git hash differs.

@MrCyjaneK

Copy link
Copy Markdown
Collaborator

Git hash that I would be more supportive of merging now is

46d146db5d3d79b1c14051c477b9ddef9e4dc287

as that's the upstream merge commit. Two commits on top shouldn't affect anything but since this is a native plugin and it touches native code in android/ dir upstream I wouldn't just assume it does nothing (and definitely wouldn't be for merging it as just CI fix)

@Blazebrain

Blazebrain commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Yes I know but it changes the ledger dependency - so we need to run full tests on ledger on this build before merging as the git hash differs.

Yeah, we can always run the tests as needed, however the difference between the old hash and the new hash is a changelog file. By the way, the old hash dad482c8 (konstantinullrich/ledger-usb-plus) was force-pushed on upstream and that's what caused the failure, this simply replaces it with minimal difference

here's exactly what the hash change is

$ git diff dad482c8 734c3d6 --stat
 CHANGELOG.md | 4 ++++
 pubspec.yaml | 2 +-      # version 1.0.6 -> 1.0.7

@MrCyjaneK

Copy link
Copy Markdown
Collaborator

oh I had a wrong tab open and check diff against the actual upstream... Force push on main branch..

@MrCyjaneK MrCyjaneK merged commit 5b2045a into dev Jul 11, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants