Engine design: config integrity, intent/output split, and chug stability fixes - #13

Open

swissskimmilk wants to merge 35 commits into

mainfrom

engine-design/bug-fixes

Commits on Jul 21, 2026

nozzle: drop unused PhysicsValidator import (combustion-efficiency fix superseded)
swissskimmilk
committed
5f7f728
Added Python linting for errors to CI/CD and fixes failures
swissskimmilk
committed
3c45435
Dead code cleanup, improved CI catching of bad syntax and practices
swissskimmilk
committed
00fa37b
thermal (layer 3): fix 386x gas viscosity unit error, add sanity and struct parity tests
swissskimmilk
committed
71c7e10
nozzle golden tests: drop retired momentum-method thrust from exit-state kernel
swissskimmilk
committed
f4d1f58
stability (layer1/2): fail-safe chug fallback, kill dead evil scoring, add gate tests
swissskimmilk
committed
607f882
thermal (layer 3): take cp/k/Pr from CEA
swissskimmilk
committed
8361291
thermal (layer 3): solve for the wall temp properly, fix old version returning initial guess due to series of bugs
swissskimmilk
committed
eaa0cf7
thermal (layer 3): fix silent dict key typos
swissskimmilk
committed
21e86ee
Seemingly working blowdowm, will continue to work on it
swissskimmilk
committed
d306feb
blowdown: share solver helpers across consumers, stop timeseries killing engine errors
swissskimmilk
committed
2ee6b55
thermal (layer 3): use gas emissivity approx for gas radiation, not the charred wall's surface value which is physically wrong
swissskimmilk
committed
6998525
thermal (layer 3): warn on kero mixes that temperature modeling is shit, validate wall solver against Huzel sample calc 4-7
swissskimmilk
committed
61c28bf
chug: forward real injector pressure drop to the stability model, stop assuming a stiff injector
swissskimmilk
committed
c31dbf2
combustion: apply Huzel Tc x eta^2, so combustion efficiency is actually piped into temperature and convert cooling's energy deficit to c* via sqrt which is correct due to units issues and recovers…
swissskimmilk
committed
2dd8cfb
config: guard that every config meets its own gates, plus per-commit metric recording
swissskimmilk
committed
95ec99d
parity: run A/B locally when the kernel is built, and compare against real Python not C
swissskimmilk
committed
a165666
backend: boot on canonical/impinging, not the presetless default.yaml that evaluates to negative thrust
swissskimmilk
committed
f65a43e
thermal: evaluate heat transfer at the combustion-corrected chamber temperature, not CEA's ideal
swissskimmilk
committed
1832596
config guard: fail only on broken configs, report off-spec ones instead of gating on them
swissskimmilk
committed
4c98024
thermal: add Bartz gas-side film coefficient, validated term-by-term against Huzel sample calc 4-3
swissskimmilk
committed
05546ba
config: share liner/insert material constants via material_preset instead of duplicating them per config
swissskimmilk
committed
bc9b719
thermal: add Bartz sigma property-variation correction, checked against Huzel figure 4-24
swissskimmilk
committed
ccd84fa
thermal: cite Huzel eq 4-14 for the Bartz sigma correction, pin the expression exactly
swissskimmilk
committed
78cd55d
config: split canonical configs into hand-authored intent and optimizer-generated design sidecar
swissskimmilk
committed
84b0b22
thermal: document Bartz provenance with Huzel page refs, distinguish eq 4-14 from figure 4-24
swissskimmilk
committed
bfad3f2
config: rename design sidecar to .outputs.yaml and move synced burn_time copy out of the intent file
swissskimmilk
committed
c2c735e
nozzle: derive throat curvature radius from the rao arc coefficients, share it with Bartz
swissskimmilk
committed
35b1108
config: move the design-point stamp to the outputs sidecar, read required chamber fields directly
swissskimmilk
committed
12d975b
thermal: add bartz_chamber_h_g, one gas-side provider for all cooling models to share
swissskimmilk
committed
2f3f234
thermal: use Bartz for the gas-side film coefficient instead of Dittus-Boelter, mirror in C
swissskimmilk
committed
832bc9c
native tests: rebuild all targets before ctest via a setup fixture, closing the stale-binary trap
swissskimmilk
committed
09ac92d
config: stamp the achieved design point (F/MR/Pc) on regeneration, add split-aware regenerate_config script
swissskimmilk
committed
2a053f9

Commits on Jul 22, 2026