refactor: merge arc-16 stack into development - #135
Conversation
* test: pin WP01 runtime contracts * fix: align WP01 import policy with adapter edges * fix: complete WP01 import graph checks
# Conflicts: # cmd/server/endpoints_mock_test.go # internal/api/drsapi/mutations.go # internal/api/internaldrs/index.go # internal/api/internaldrs/inspect.go # internal/api/internaldrs/repair_cleanup.go
# Conflicts: # cmd/server/endpoints_mock_test.go # cmd/server/server.go # internal/api/drsapi/objects_test.go # internal/api/internaldrs/bucket_helpers.go # internal/api/internaldrs/bucket_routes_test.go # internal/api/internaldrs/buckets.go # internal/api/internaldrs/inspect.go # internal/api/internaldrs/inspect_routes_test.go # internal/api/internaldrs/transfer.go # internal/api/internaldrs/upload_routes_test.go # internal/api/lfs/actions_test.go # internal/api/lfs/upload_proxy_test.go # internal/common/checksum_test.go # internal/common/identity.go # internal/common/misc_test.go # internal/common/util_test.go # internal/core/bucket_catalog.go # internal/core/content_identity_regression_test.go # internal/core/converters.go # internal/core/object_storage_delete.go # internal/core/object_storage_delete_test.go # internal/core/storage_signing.go # internal/core/storage_signing_legacy_test.go # internal/db/interface.go # internal/models/storage.go
Consolidate server plugin examples, flatten the schema submodule, and move shared resource and checksum helpers into the client module. Remove stale documentation and test drivers, update coverage and build targets, and verify installer replacement and resumable multi-module release preparation. BREAKING CHANGE: github.com/calypr/syfon/common is removed. Import resource helpers from github.com/calypr/syfon/client/access and NormalizeOid and NormalizeChecksum from github.com/calypr/syfon/client/hash. Existing client exports and the server plugin contract remain unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ Deploy Preview for drs-server ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28195aaa75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if rb.NoRetry || !requestCanRetry(httpReq) { | ||
| resp, err := r.RetryClient.HTTPClient.Do(httpReq) |
There was a problem hiding this comment.
When NewBearerTokenRequestor is given an API key/endpoint for refresh and the current access token has expired, any POST, PUT, PATCH, or DELETE now bypasses RetryClient.Do, so a 401 is returned without invoking the CheckRetry hook that calls refreshIfCurrent. This regresses previously working writes for long-lived clients until they happen to issue a refreshable GET; unsafe status-based retries can remain disabled, but the 401 refresh-and-replay path needs to be preserved separately (the generated-client bypass in generatedHTTPDoer has the same issue).
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
1 participant
This is the umbrella PR for the existing architecture stack, proposing the preserved
refactor/arc-16tip directly againstdevelopment.The incremental stack remains represented by PRs #117 through #128 and tip PR #134. This PR contains the complete stack result, including the SDK README, release versioning, dependency, and workflow security fixes at the
arc-16tip.Dependabot-authored PRs #94, #95, and #112 remain separate.