docs: name the command line tools in the pitch table - #171
Merged
Conversation
"Why This Library?" compared five dimensions and left out the commands, so a reader of the pitch never learned the gem ships any executable, let alone the keywords tool added in 2.7.0. The gem installs classifier and keywords. classifier-reborn, the fork the table compares against, ships neither: it has no bin/ and no exe/, so its gemspec grep over ^bin/ yields an empty executables array.
The table claimed 5 classifiers. Only four of the five classes classify:
Bayes classify:true
LSI classify:true
KNN classify:true
LogisticRegression classify:true
TFIDF classify:false transform:true
TF-IDF is a vectorizer. It turns text into term weights and never returns
a category. The gemspec summary already draws this line, saying "Bayesian,
LSI, Logistic Regression, kNN, and TF-IDF vectorization".
Name the fork's side too. classifier-reborn ships bayes.rb and lsi.rb,
which is where the "2 only" comes from.
Contributor
Greptile SummaryAdds the names of the gem’s two packaged command-line tools to the feature comparison table.
Confidence Score: 5/5The documentation-only change appears safe to merge. The new table row accurately names both executables packaged by this gem, and no concrete changed-code-triggered failure or repository-rule violation remains. Important Files Changed
Reviews (1): Last reviewed commit: "docs: name the command line tools in the..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No. The "Why This Library?" table compared five dimensions and never mentioned the commands, so a reader of the pitch never learned the gem ships any executable, let alone the
keywordstool added in 2.7.0.| **Algorithms** | ✅ 5 classifiers | ❌ 2 only | + | **Command line** | ✅ `classifier` and `keywords` commands | ❌ No executables | | **Incremental LSI** | ✅ Brand's algorithm (no rebuild) | ❌ Full SVD rebuild on every add |The claim is verified
This gem installs two executables:
classifier-reborn, the fork this table compares against, ships none. It has nobin/and noexe/directory (both 404 on the GitHub contents API), and its gemspec builds the executable list by grepping^bin/:With no
bin/directory that grep returns an empty array, so the published gem installs no commands.This is arguably the strongest row in the table: the others are differences of degree, while this is a capability the fork lacks entirely.
Verified
Noted, not changed
The one-line headline above the table has the same omission:
Adding the CLI there would be consistent, but it is a separate editorial call so I left it alone.