Align funded_project references with project titles (retire the remap) - #86
Open
bendichter wants to merge 3 commits into
Open
bendichter wants to merge 3 commits into
bendichter wants to merge 3 commits into
Conversation
Several conversions referenced funded projects by a different name than the project's own title, so the affiliated-conversions logic needed a hard-coded remap table to reconcile them: - "Aligning Science Across Parkinson's" -> "ASAP NWB Adoption" (13) - "Ripple U19" -> "Ripple U19 NWB Adoption" (4) - "NYU Librarians" -> "NYU Librarians NWB Adoption" (2) This updates the funded_project value in those conversions to match the project title exactly, then removes the remap in FundedProject.tsx and the equivalent slug special-cases in NWBConversions.tsx. Affiliated conversions and the funded-project links now resolve by direct title match. Verified with a full build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ Deploy Preview for catalystneuro ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…project Rather than renaming the 13 ASAP conversions to the project's short title, this renames the project itself to its full name, which is the better display label. The conversions already referenced "Aligning Science Across Parkinson's", so they now match the project title directly and are reverted to their original values. The Ripple U19 and NYU Librarians conversions are still normalized to their project titles. Verified with a full build: the project page renders at /funded-projects/aligning-science-across-parkinson-s with its affiliated conversions intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bendichter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several NWB conversions referenced their funded project by a different name than the project's own
title. To reconcile them,FundedProject.tsxcarried a hard-coded remap table andNWBConversions.tsxcarried matching slug special-cases. That is fragile: every new naming mismatch needs another branch in the code.This makes each conversion's
funded_projectequal to its project'stitle, so the reconciliation code can be removed. The direction differs per project so the display name stays the nicest option in each case:Aligning Science Across Parkinson'sRipple U19 NWB AdoptionNYU Librarians NWB AdoptionThe ASAP project keeps its full name, "Aligning Science Across Parkinson's", instead of the shorter "ASAP NWB Adoption". Its 13 conversions are unchanged from
main.With the values aligned, the reconciliation code is gone:
FundedProject.tsx— the affiliated-conversions filter is now a directconv.funded_project === projectTitlematch.NWBConversions.tsx— the funded-project link slug is now a plain slugify offunded_project.Verification
Ran a full
npm run build. Affiliated-conversions sections still populate: the Aligning Science Across Parkinson's page (/funded-projects/aligning-science-across-parkinson-s) lists the Dombeck, Lerner, Turner, Higley, Schwerdt (and more) conversions, and the Ripple U19 page lists Buzsaki, Losonczy, Schnitzer, and Soltesz.🤖 Generated with Claude Code