Skip to content

Make row-by-row table writing linear in the number of rows - #1920

Merged
h-mayorquin merged 3 commits into
mainfrom
fix_dynamic_table_bug
Aug 15, 2026
Merged

Make row-by-row table writing linear in the number of rows#1920
h-mayorquin merged 3 commits into
mainfrom
fix_dynamic_table_bug

Conversation

@h-mayorquin

Copy link
Copy Markdown
Collaborator

When working on the pyPhotometry converter I realized that a twelve-minute recording was taking 81 seconds to write its events table. DynamicTable.add_row calls hdmf's is_ragged on the whole column after appending each value. So filling a table is quadratic in its rows, and none of these tables can hold a ragged cell anyway. This PR passes check_ragged=False in the five writers whose row count grows with the data.

@h-mayorquin
h-mayorquin merged commit 6b51b9e into main Aug 15, 2026
3 of 5 checks passed
@h-mayorquin
h-mayorquin deleted the fix_dynamic_table_bug branch August 15, 2026 15:54
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.19%. Comparing base (59635e2) to head (8675ce5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1920   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files         211      211           
  Lines       18508    18508           
=======================================
  Hits        15767    15767           
  Misses       2741     2741           
Flag Coverage Δ
unittests 85.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oconv/datainterfaces/events/baseeventsinterface.py 98.57% <100.00%> (ø)
...faces/fiber_photometry/guppy/guppydatainterface.py 98.83% <100.00%> (ø)
src/neuroconv/tools/behavior.py 100.00% <100.00%> (ø)
src/neuroconv/tools/icephys.py 98.06% <100.00%> (ø)
src/neuroconv/tools/roiextractors/roiextractors.py 70.49% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant