Make row-by-row table writing linear in the number of rows - #1920
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
=======================================
Coverage 85.19% 85.19%
=======================================
Files 211 211
Lines 18508 18508
=======================================
Hits 15767 15767
Misses 2741 2741
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on the pyPhotometry converter I realized that a twelve-minute recording was taking 81 seconds to write its events table.
DynamicTable.add_rowcalls hdmf'sis_raggedon the whole column after appending each value. So filling a table is quadratic in its rows, and none of these tables can hold a ragged cell anyway. This PR passescheck_ragged=Falsein the five writers whose row count grows with the data.