Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions core.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,25 @@ def validate_encoding(_ctx, _param, value):
)


def validate_standard(standard: str, custom_standard: bool, logger, ctx) -> str:
if custom_standard:
return standard

normalized_standard = standard.lower()
supported_standards = StandardTypes.values()

if normalized_standard not in supported_standards:
supported_list = ", ".join(sorted(supported_standards))
logger.error(
f"Standard '{standard}' is not a supported standard. "
f"Supported standards: {supported_list}. "
f"Use --custom-standard flag for custom standards."
)
ctx.exit(2)

return normalized_standard


def valid_data_file(data_path: list) -> tuple[list, set]:
allowed_formats = [
DataFormatTypes.XPT.value,
Expand Down Expand Up @@ -653,17 +672,7 @@ def validate( # noqa
if resolved.is_file():
define_xml_path = str(resolved)

if not custom_standard:
standard = standard.lower()
supported_standards = StandardTypes.values()
if standard not in supported_standards:
supported_list = ", ".join(sorted(supported_standards))
logger.error(
f"Standard '{standard}' is not a supported standard. "
f"Supported standards: {supported_list}. "
f"Use --custom-standard flag for custom standards."
)
ctx.exit(2)
standard = validate_standard(standard, custom_standard, logger, ctx)

if raw_report:
if not (len(output_format) == 1 and output_format[0] == ReportTypes.JSON.value):
Expand Down
42 changes: 42 additions & 0 deletions tests/unit/test_core.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
from unittest.mock import MagicMock

import pytest

from core import validate_standard


def test_validate_standard_accepts_supported_value():
logger = MagicMock()
ctx = MagicMock()

result = validate_standard("SDTMIG", False, logger, ctx)

assert result == "sdtmig"
logger.error.assert_not_called()
ctx.exit.assert_not_called()


def test_validate_standard_rejects_typo():
logger = MagicMock()
ctx = MagicMock()
ctx.exit.side_effect = SystemExit(2)

with pytest.raises(SystemExit) as exc_info:
validate_standard("stdtmig", False, logger, ctx)

assert exc_info.value.code == 2
logger.error.assert_called_once()
message = logger.error.call_args.args[0]
assert "stdtmig" in message
assert "sdtmig" in message


def test_validate_standard_allows_custom_standard():
logger = MagicMock()
ctx = MagicMock()

result = validate_standard("cust_standard", True, logger, ctx)

assert result == "cust_standard"
logger.error.assert_not_called()
ctx.exit.assert_not_called()
Loading