Ap identification - #1854
Conversation
pendingintent
left a comment
There was a problem hiding this comment.
AP-- will not have an associated domain other than APRELSUB. MH will not have a relationship to APMH. All AP domains are only to record details for a person associated with a USUBJID. There is no parent/child relationship with AP--. The suffix only indicates the type of data collected in the dataset. In this case, this is medical history for the associated person. The APID in APMH will join to APRELSUB.APID and the APRELSUB.USUBJID will indicate to which subject the person is associated.
|
I removed the logic for AP that I preserved, that was built on a false premise. I updated tests as the ap_suffix had several failing tests where there was no metadata on the dataset--meaning a dataset was submitted but completely empty. It no longer returns "" and instead would error out given the total lack of metadata. I would expect this given the blank data which would force a rule skip for that dataset and rule |
This PR updates logic for identifying AP class which used to seek out the parent dataset then ID based on that. This PR still uses that logic, if it fails, it attempts to use the AP suffix--testing it in the case of both standard and custom domains attached to AP--.