Skip to content

Build pr images with pr branch head #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
piersy wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Build pr images with pr branch head #76

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e03641
Ensure that docker builds for PRs use HEAD commit
piersy Dec 9, 2025
881f099
Add backup for non PR action triggers
piersy Dec 9, 2025
11bd78d
Try another approach
piersy Dec 9, 2025
a536cec
Actually checkout the head commit
piersy Jan 20, 2026
4362df8
Merge branch 'develop' into piersy/build-pr-images-with-pr-branch-head
piersy Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/push-container.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ jobs:
- id: meta
uses: docker/metadata-action@v5
with:
# By default for PRs checkout will checkout the pr merge commit which
# is maintained by github and is the PR branch merged into the default
# branch and then use that ephemeral commit to build with. This is
# highly confusing when building docker images since the tags don't
# relate to any accessible commits. The fix is to ensure we use the
# head commit sha. See -
# https://github.com/actions/checkout?tab=readme-ov-file#checkout-pull-request-head-commit-instead-of-merge-commit
ref: ${{ github.event.pull_request.head.sha }}
images: ${{ inputs.artifact-registry }}
tags: |
type=semver,pattern={{version}},match=celo/v(.*)
Expand Down
Loading