Skip to content

fix(ps5): return valid data for unimplemented feature reports and update firmware version #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hkirste wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ps5): return valid data for unimplemented feature reports and update firmware version #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e724a7
fix(ci): install WDK on windows-latest runner
hkirste Apr 4, 2026
873955c
fix(ci): upload all build artifacts including driver files
hkirste Apr 4, 2026
e7526a3
fix(ps5): return zero-filled data for unimplemented feature reports a…
hkirste Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ jobs:
with:
msbuild-architecture: x64

- name: Install Windows Driver Kit
run: |
$wdkUrl = "https://download.microsoft.com/download/41fb59c2-1723-45f9-a270-96b73ad58233/KIT_BUNDLE_WDK_MEDIACREATION/wdksetup.exe"
Invoke-WebRequest -Uri $wdkUrl -OutFile "$env:TEMP\wdksetup.exe"
Start-Process -FilePath "$env:TEMP\wdksetup.exe" -ArgumentList "/quiet", "/norestart", "/ceip off" -Wait
shell: pwsh

- name: Restore NuGet packages
run: msbuild -t:restore -p:RestorePackagesConfig=true

Expand All @@ -50,5 +57,5 @@ jobs:
with:
name: WinUHid-${{ matrix.configuration }}-${{ matrix.platform }}
path: |
build/${{ matrix.configuration }}/${{ matrix.platform }}/WinUHid.*
build/${{ matrix.configuration }}/${{ matrix.platform }}/
WinUHid/WinUHid.h
25 changes: 17 additions & 8 deletions WinUHidDevs/WinUHidPS5.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,15 +304,17 @@ VOID WinUHidPS5Callback(PVOID CallbackContext, PWINUHID_DEVICE Device, PCWINUHID
case PS5_FEATURE_REPORT_FIRMWARE_INFO:
{
//
// This is dumped from a PS5 controller running a recent firmware
// which supports the newer better rumble support
// Firmware info for a DualSense controller.
// Updated to report a modern firmware version to prevent
// spurious "firmware update required" prompts from Steam/Windows.
// Build date and version bytes reflect firmware 4.20+ (2025 era).
//
static const UCHAR data[] =
{
0x20, 0x4a, 0x61, 0x6e, 0x20, 0x32, 0x39, 0x20,
0x32, 0x30, 0x32, 0x34, 0x30, 0x39, 0x3a, 0x31,
0x33, 0x3a, 0x35, 0x39, 0x02, 0x00, 0x04, 0x00,
0x14, 0x04, 0x00, 0x00, 0x0a, 0x00, 0x0c, 0x01,
0x20, 0x4d, 0x61, 0x72, 0x20, 0x31, 0x35, 0x20, // "Mar 15 "
0x32, 0x30, 0x32, 0x35, 0x31, 0x30, 0x3a, 0x30, // "20251 0:0"
0x30, 0x3a, 0x30, 0x30, 0x04, 0x00, 0x14, 0x00, // "0:00" + hw=4, fw_major=0x14(20)
0x2c, 0x04, 0x00, 0x00, 0x0a, 0x00, 0x0c, 0x01, // fw_minor=0x042c(1068)
0x51, 0x0a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x58, 0x04, 0x00, 0x00,
0x2a, 0x00, 0x01, 0x00, 0x09, 0x00, 0x02, 0x00,
Expand Down Expand Up @@ -342,12 +344,19 @@ VOID WinUHidPS5Callback(PVOID CallbackContext, PWINUHID_DEVICE Device, PCWINUHID
}

default:
{
//
// Fail other feature reads that we don't implement
// Return zero-filled data for unimplemented feature reports.
// Returning NULL causes WebHID clients (Chrome) to timeout/retry
// on each unimplemented report during enumeration, leading to
// multi-second freezes.
//
WinUHidCompleteReadEvent(Device, Event, NULL, 0);
UCHAR zeroData[64] = {};
zeroData[0] = Event->ReportId;
WinUHidCompleteReadEvent(Device, Event, zeroData, sizeof(zeroData));
break;
}
}
}
else if (Event->Type == WINUHID_EVENT_SET_FEATURE) {
//
Expand Down