Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expect(() => { throw null; }).to.throw(TypeError)currently passes because the constructor/message checks require a truthy thrown value. The same false positive affectsundefined,false,0,NaN, and the empty string. Negated message assertions also miss an empty thrown string.Use the existing
errorWasThrownflag to decide whether to check constraints. Guard nullish values before calling the error helpers, so mismatches produce an AssertionError instead of a property-access TypeError. Add regressions for constructors, error instances, strings/regular expressions, and negated empty-string matches.Validation:
npm run buildandnpm run lint: pass.npm run test-node: 515 passing, coverage check passes.git diff --check: pass.AI assistance: OpenAI
gpt-6.1-solwith xhigh reasoning was used to investigate, implement, and validate this change.