Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing a global or sticky RegExp makes
.match()depend on its previouslastIndex. A valid positive assertion can fail, and a negated assertion can silently pass for the same matching input after an earlier match.Evaluate stateful expressions from index zero and restore the caller's index before reporting the assertion result. Ordinary expressions are evaluated without mutation, including frozen regexps. Add regressions for repeated matches, existing index preservation, negated false positives, and frozen ordinary expressions.
Validation:
npm run buildandnpm run lintpass.git diff --checkpasses.Discovery and implementation: automated OpenAI
gpt-6.1-solsource review, xhigh reasoning.