Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric change assertions validate the initial subject but do not validate the value observed after invoking the target function. A counter changing from numeric
1to string"2"incorrectly passes.increase(), and changing to string"0"incorrectly passes.decrease(). A final undefined value silently passes their negated forms because arithmetic produces NaN.Check the final observed value using the same numeric prerequisite as the initial value, before calculating the delta. This covers object properties and getter callbacks, including negated assertions and custom error messages. Existing valid numeric changes retain their behavior.
Validation:
npm run buildandnpm run lintpass.npm run test-node: 515 passing; Chromium suite with the local Chrome executable: 514 passing.git diff --checkpasses.Discovery and implementation: automated OpenAI
gpt-6.1-solsource review, xhigh reasoning.