Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact
.all.deep.keysmatching can reuse one actual Map or Set key for multiple structurally equal expected keys. For example, keys{id: 1}and{id: 2}currently pass an expectation of[{id: 1}, {id: 1}], leaving the second actual key unchecked.Match against a shallow copy of the actual keys and consume each match for exact comparisons. Keep
.includeand.anybehavior. Add Map and Set regressions, negation checks, valid repeated deep-equal keys, and inclusion/any controls.Validation:
npm run test-node: 514 tests pass.git diff --checkpass.lint:typesreports the same 601 existing diagnostics on main and the patched source, with identical diagnostic multisets. That script is not part of the current CI workflows.Discovery and implementation: automated OpenAI
gpt-6.1-solsource review with xhigh reasoning; no production incident is claimed.