Repository navigation
ci: name jobs and workflow files after what they do - #354
Merged
Merged
Conversation
Contributor
OpenTofu Plan |
A job name is the status check context, so it is read in the ruleset's list next to biome, phpcs and phpunit, where `build` and `build-and-check` say nothing. Renames only, no behaviour change: build -> docker-image build-and-check -> smoke build-and-deploy -> deploy-pages The first two are required contexts, so the ruleset has to drop the old names before this merges and pick up the new ones after. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BJtGZbbjBAHWmnC4QQyRUj
The file name is what a reader scans first, so it should agree with the workflow and its job: docker-build.yml -> docker-image.yml (workflow "Docker image", job docker-image) tf.yml -> tofu.yml (workflow "Tofu") Also drops .github/workflows/dependencies, a stray file from be87a48 that holds a fragment of phan's Gadgets config. GitHub ignores it; it is not a workflow. .tf/ruleset.tf carries the renamed contexts, since the required checks are declared there, not in the web UI. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BJtGZbbjBAHWmnC4QQyRUj
lens0021
force-pushed
the
ci/specific-job-names
branch
from
August 15, 2026 14:49
62742df to
b136dff
Compare
This was referenced Aug 15, 2026
lens0021
added a commit
that referenced
this pull request
Aug 15, 2026
The two shipped composite actions sat at the repo root as `action/` and `action-check/`, sorting apart from each other and reading as leftovers. They move to `actions/bake/` and `actions/check-translations/`, each directory named after what the action does, the way #354 named the workflows. Breaking for anyone referencing `chaotic-ground/wikven/action@<ref>`: that becomes `chaotic-ground/wikven/actions/bake@<ref>`. The docs example moves with it. Still v0, so this is the moment to do it. Renaming the paths meant auditing the config keyed on them, which turned up two things that were already broken: - release-please only listed `action/action.yml` as an extra file, so the `x-release-please-version` pin in the check action has never been stamped. Both are listed now. - Dependabot 🤖 Generated with [Claude Code](https://claude.com/claude-code)'s `github-actions` entry is `directory: /`, which scans `.github/workflows` and a root `action.yml` only. Neither composite action was ever in its view, and `git log --author=dependabot -- action/action.yml` is empty to prove it. It is `directories: [/, /actions/*]` now, so the glob picks up whatever lands there next. `pr-preview` and `deploy-docs` also gained `actions/bake/**` in their path filters. The preview build is the only thing anywhere that runs that action, and it was not watching it, which is the same shape of bug #344 just fixed for the binary. Verified: `yamllint --strict .` passes, the release-please config still parses, and a repo-wide grep finds no surviving reference to the old paths. Because this touches `docs/`, `pr-preview` runs on this PR and exercises `./actions/bake` from its new location. Not done here: `docs/Deploying/ko.wikitext` carries the old `tree/main/action` link and will go fuzzy and 404 until someone updates ko. Translating is not the code contributor's job. The check action is still run by no CI anywhere, which is worth its own issue. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A job id is the status check context. It is read in the ruleset's required-checks list, next to
biome,phpcs,phpunit (master)andtypos, wherebuildandbuild-and-checksay nothing about what ran. #344 also showed the concrete cost: a second job namedbuildput two same-named check runs on one commit and made the required-check verdict depend on which reported last. File names get the same treatment, so a reader scanning.github/workflows/sees what each one runs.Renames only, no behaviour change.
docker-image.ymlbuilddocker-imagesmoke.ymlbuild-and-checksmokedeploy-docs.ymlbuild-and-deploydeploy-pagesdocker-build.ymldocker-image.ymltf.ymltofu.ymlsmoke.ymlbakes the docs site, asserts the output, then runs the browser tests, sobakewould have covered half of it.deploy-pagesis what the job actually does: publish to thegh-pagesbranch.tofu.ymlmatches the workflow's own name and the tool it runs.The
uses:inrelease-please.yml, the path filter intofu.yml, and the two prose references insmoke.ymlandpr-preview.ymlfollow the file renames. Nothing references the three job ids.Also drops
.github/workflows/dependencies, a stray file from be87a48 holding a fragment of phan's Gadgets config. It has no extension, so GitHub never treated it as a workflow.The required contexts live in Terraform
.tf/ruleset.tfdeclares the required checks, so it carries the renamed contexts here rather than being clicked in the web UI.Renaming a required context cannot be a single step: while the ruleset still requires
build, this pull request can never satisfy it, because the job now reports asdocker-image. Sobuildandbuild-and-checkwere dropped from the live ruleset through the API first, which is what let this pull request go green. Applying this branch's.tfafter merge putsdocker-imageandsmokein their place and clears the drift.Between those two moments the two gates are off.
deploy-pagesandbinaryare not required contexts and need neither step.