Repository navigation
chore(main): release 1.1.0 - #618
Merged
Merged
Conversation
github-actions
Bot
force-pushed
the
release-please--branches--main
branch
2 times, most recently
from
September 2, 2026 17:34
5539ffc to
cd542f2
Compare
lens0021
added a commit
that referenced
this pull request
Sep 2, 2026
Split out of #623, which now stacks on this. ## The defect `SiteConfig::lint()` reads a site's `WikvenSiteUrl` through `SiteUrl`, and ran twenty lines above the `require_once` that loads it. Any site that actually set the value fataled at `LocalSettings` time: Fatal error: Uncaught Error: Class "MediaWiki\Extension\Wikven\SiteUrl" not found in /var/www/html/WikvenSettings.php CI never saw it. The path is behind `$siteUrl !== ''` and no test site set one, so the only setting #621 added was broken on its only non-default path with all 26 checks green. `docs/.wikven.yaml` now names the documentation site's own URL. That is what stops this recurring: the path is in every bake CI runs, and it fills `$wgCanonicalServer` besides, so an absolute URL MediaWiki or an extension builds names the right host instead of `localhost`. ## Why this is a chore and not a fix The defect was introduced by #621, and #621 has not been released — it is sitting in the pending 1.1.0 (#618). Nobody running 1.0.0 ever had this bug. `.release-please-config.json` shows `fix` under a visible "Bugfixes" section, so typing this as a fix would put a line in 1.1.0's notes describing a defect no released version carried. `chore` is hidden, which is the right answer for repairing unreleased work. The commit message says the same, so the reasoning survives the squash. ## Checked locally Built with the released binary over this working tree: - A site setting `WikvenSiteUrl` — reproduced the fatal, then confirmed the build completes and writes its pages. - `$wgCanonicalServer` comes out as `https://chaotic-ground.github.io` where `WikvenSiteUrl` is `https://chaotic-ground.github.io/wikven/` — the host half, path left to wikven. - `phpcs` (60 files), `mago format --check`, `mago lint`, `yamllint` all clean. `phpcs` now runs here, which it did not for the three lint failures earlier in this stack: `phpcsstandards/phpcsextra` was installed but its sniff path was not registered, so every `Universal.*` reference errored out. Registering `installed_paths` fixed it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn --- _Generated by [Claude Code](https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn)_ Co-authored-by: Claude <noreply@anthropic.com>
github-actions
Bot
force-pushed
the
release-please--branches--main
branch
14 times, most recently
from
September 6, 2026 11:47
b8cf1cd to
56720a2
Compare
lens0021
added a commit
that referenced
this pull request
Sep 6, 2026
…use it (#676) `CHANGELOG.md` and the releases page list every change, generated from the commits, for people tracking the repository. Nothing says what a release means to somebody who *uses* wikven — and the generated list cannot: it is grouped by commit type, it omits everything `.release-please-config.json` hides (`refactor`, `test`, `docs`, `ci`), and it is written in the register of the diff. `Release notes/1.1.0` is that page for the release waiting in #618. Three things a reader of this site would notice get sections — a site that can say where it is, a build that stops on a page it rendered wrong, a licenses page that names the server — and the rest is a list at the bottom. ## The draft hatnote A release page is written before its release exists, so it says so until the release catches up. `Template:draft` compares the version in the page's own title with `{{WIKVENVERSION}}`, the version of the Wikven that built the page, and shows the notice only while the first is newer. **Nothing is edited when the release happens.** The bake that publishes it is built by it, so the comparison stops being true and the notice stops rendering. Both halves are wikitext, not Lua. `#explode` reads a version out of the title and out of `{{WIKVENVERSION}}`, `Template:draft/number` turns each into one number so that `1.10.0` sorts after `1.9.0` rather than before it, and one `#ifexpr` compares them. That needs `PFEnableStringFunctions`, which ParserFunctions keeps off by default and `docs/.wikven.yaml` now turns on for this site — the reason it is off is a wiki that takes edits from anyone, and this one is a directory of files rendered once at build time. A version neither can read is `0`, which is what leaves the template a single comparison with no guard around it: | case | named | built | hatnote | | --- | ---: | ---: | --- | | the page is about an unreleased version | 1001000 | 1000000 | shown | | the release lands | 1001000 | 1001000 | gone, by itself | | a later release | 1001000 | 1002000 | still gone | | the page is not a release page | 0 | 1000000 | none | | the build will not say which version it is | 1001000 | 0 | shown — a draft shown as published is the failure worth avoiding | ## Checked The comparison is simulated against ParserFunctions' own `runExplode()` and `#expr`'s number reading, over twelve cases: the release landing and the one after it, `1.10.0` against `1.9.0` in both directions, `1.1` and `1.1.0` as one version written two ways, an empty and a non-version `{{WIKVENVERSION}}`, and two pages that are not release pages. All twelve answer as intended. Not baked here, so the rendering itself is unproven — the preview job is what will show it, and I will read it when it does. `yamllint` passes on the edited `.wikven.yaml`. Neither page carries `<translate>` or `<languages />`, so `translate check` has nothing to say about them and the `language-bars` assertion is unaffected. ## Two names The page is titled **Release notes** and displays **What's new**. An apostrophe in a title reaches the canonical link percent-encoded, and the `head-links` bake check looks the file up without decoding it, so `What's new/1.1.0` would have failed a check on its punctuation. The words readers see are the ones worth having; the string machines see only has to be safe. ## Left for you - Nothing links either page yet, and neither is in the sidebar, so `Module:Sequence.lua` writes no navigation row for them. Worth linking from the front page when 1.1.0 ships. - The prose is a first draft of a judgement call — which changes are worth a reader's attention and which are a line at the bottom. That is yours to move. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn --- _Generated by [Claude Code](https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
lens0021
marked this pull request as draft
September 6, 2026 13:15
github-actions
Bot
force-pushed
the
release-please--branches--main
branch
8 times, most recently
from
September 8, 2026 14:50
6aa9cbf to
b22fbb5
Compare
github-actions
Bot
force-pushed
the
release-please--branches--main
branch
14 times, most recently
from
September 10, 2026 15:34
cfdf47d to
c0686c0
Compare
lens0021
added a commit
that referenced
this pull request
Sep 10, 2026
#744 landed as `feat:`. It is not one: `.tf/` says how GitHub is configured, and a reader of the release notes has no wiki that behaves differently for it. release-please read the label it was given and put it under **Features** in #618. ## What can and cannot be corrected A merged commit's type cannot be changed — `main` takes no rewrite, and release-please offers nothing that retypes an earlier commit. `Release-As:` is the one footer that reaches back, and it would change nothing here anyway: ten other `feat:` commits since 1.0.0 already settle the minor bump, so 1.1.0 is 1.1.0 either way. The mistake cost a changelog line, not a version. What the configuration does offer is `exclude-paths`, which drops a commit whose every file sits under one of the named paths — before the type is ever read. So this is not a correction of one commit but of the rule that let it through: nothing under `.tf/` reaches a release again, however it is labelled. ## Effect release-please re-reads the range on every run, so #618 loses the entry on the next one. Of every commit since 1.0.0, exactly one touches nothing but `.tf/` — #744 — so that is the only line that moves. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn --- _Generated by [Claude Code](https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn)_ Co-authored-by: Claude <noreply@anthropic.com>
github-actions
Bot
force-pushed
the
release-please--branches--main
branch
6 times, most recently
from
September 17, 2026 13:05
c61f076 to
2c28d5a
Compare
lens0021
marked this pull request as ready for review
September 20, 2026 05:03
github-actions
Bot
force-pushed
the
release-please--branches--main
branch
from
September 20, 2026 05:03
2c28d5a to
3e3449b
Compare
Contributor
Author
|
🤖 Created releases: 🌻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
1.1.0 (2026-09-20)
Features
Bugfixes
Performance
This PR was generated with Release Please. See documentation.