Repository navigation
docs: say what the download services do, not what one did once - #755
Merged
Merged
Conversation
The comment beside CURL_RETRY dates an outage. What the retries are for is that the service in front of the bytes answers 429 under load and sometimes nothing at all, which is true on any day. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn
lens0021
added a commit
that referenced
this pull request
Sep 11, 2026
The last line of `Scribunto`'s class docblock is about the time before
the class:
```diff
* Whether this build can render Lua, and what to say when it cannot.
*
* wikven's two products disagree: the image compiles luasandbox into its PHP, while the binary
* reaches Lua only by shelling out, which it can on 64-bit x86 Linux and nowhere else.
- *
- * That used to be silent -- a page invoking a module rendered "{{#invoke:Greet|hello}}".
*/
```
It is saying twice over what is already there. The first line says the
class exists to say something when Lua cannot be rendered, and the
symptom it names is in the message the class returns, thirty lines down:
```php
. ' is not in extensions, so a {{#invoke:}} is left in the page as its own source text,'
```
A reader who wants to know what a reader sees finds it where the text is
written, in the present tense, rather than in a docblock's account of
how things once were.
### Where this sits
`Scribunto` is a small pure class asked two questions by `build.php`: is
this a build that can render Lua at all (`problem()`), and is this a
site that will notice (`warning()`). The split matters because wikven
ships two products with different answers — the image compiles
luasandbox into its PHP; the binary shells out to a Lua interpreter,
which Scribunto bundles for 64-bit x86 Linux and nowhere else. A site
with no `Module:` pages is told nothing either way.
Same clean-up as #751, #754 and #755. The comment budget reads 3.30
words a line against a ceiling of 4.00 afterwards.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn
---
_Generated by [Claude
Code](https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn)_
Co-authored-by: Claude <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment beside
CURL_RETRYin theDockerfiledates an outage:A reader wondering why the image retries its downloads does not need the afternoon; they need what those services do on any day. The second half of that sentence already said it in the present tense, so the fix is to finish the thought and drop the date.
The clause that matters is untouched:
--retry-all-errorson top of--retry, because curl reads a connection reset as permanent and will not try that one again on its own.Where this sits
CURL_RETRYis a build argument theDockerfilepasses to everycurlin it — SifterSearch's release tarball, Translate's and UniversalLanguageSelector's source archives. Those are pinned by tag or commit, so the bytes never change; what can fail is the host handing them over. Three lines above it,CURL_AGENTis the other half of the same idea: the image says who is asking.Same clean-up as #751 and #754, in the one file outside CI that had it.
🤖 Generated with Claude Code
https://claude.ai/code/session_019ghEx26MRm9V5CnCLrdUQn
Generated by Claude Code