Repository navigation
fix: keep plain spaces in code, where MediaWiki makes them no-break - #834
Merged
Merged
Conversation
Core's French spacing runs inside <pre> and <code> too, so the space in `a != b` became U+00A0 and copied code carried it. The rendered HTML now gets those spaces back inside code only. Prose keeps its no-break spaces, and so does one in code that the rule did not write. Fixes #833 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RALhBwbiZGrBpprRuUjAkK
lens0021
added a commit
that referenced
this pull request
Oct 9, 2026
The required master jobs (phpunit, phan, coverage) fail on every branch since core master's `ForeignAPIRepo::getThumbUrlFromCache()` started taking a `ForeignAPIFile` instead of a name (`TypeError` in `RetryingForeignRepoTest`, seen on #834). The override now names the file from either argument, and the test passes whichever argument the running core's signature takes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01RALhBwbiZGrBpprRuUjAkK Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
lens0021
pushed a commit
that referenced
this pull request
Oct 9, 2026
🤖 I have created a release *beep* *boop* --- ## [1.4.1](v1.4.0...v1.4.1) (2026-10-09) ### Bugfixes * keep plain spaces in code, where MediaWiki makes them no-break ([#834](#834)) ([57d0661](57d0661)) * take the file MediaWiki 1.47 passes to a thumbnail lookup ([#835](#835)) ([4bb50d9](4bb50d9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #833
Inside
<pre>and<code>, which also covers SyntaxHighlight's output, the rendered page now has a plain space whereverSanitizer::armorFrenchSpaceshad put U+00A0 (before!?:;%»›that is not followed by a word character, and after«‹). A newParserOutputPostCacheTransformhandler does it. Prose keeps its no-break spaces, and so does one in code that the rule did not write.Tests: a unit test covers
<pre>,<code>, SyntaxHighlight's YAML output and the form, plus prose and an author's no-break space left alone. An integration test runs core's parse and output pipeline on<pre>a != b</pre>,<code>a != b</code>and prosea !.🤖 Generated with Claude Code
https://claude.ai/code/session_01RALhBwbiZGrBpprRuUjAkK