Repository navigation
build(deps): move the golangci-lint and rumdl pins out of lint.yml - #853
Merged
Merged
Conversation
Updatecli pushes with GITHUB_TOKEN, which may not change a workflow file, so the two pins written in lint.yml never moved and the weekly run failed. Pin rumdl in pyproject.toml beside yamllint and golangci-lint in a Go module of its own, where Dependabot's uv and gomod updates already reach, and read both from there. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxoPoPfm7NKhbhskvX5oR7
The project is PHP and Go; Python stays out of it. rumdl ships on npm beside its Rust binary, and package.json is already where Dependabot moves the JavaScript tooling. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxoPoPfm7NKhbhskvX5oR7
The project is PHP and Go, and neither Python nor npm belongs in it to install a Rust linter. Updatecli keeps bumping rumdl, now in .tool-versions, which GITHUB_TOKEN may push to. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxoPoPfm7NKhbhskvX5oR7
lens0021
changed the title
lens0021
marked this pull request as ready for review
October 13, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by lens0021 · project thread
Before: golangci-lint and rumdl were pinned inside
.github/workflows/lint.ymland bumped by updatecli. Updatecli pushes withGITHUB_TOKEN, which may not change a workflow file, so neither pin ever moved. The weekly Updatecli run has failed every week since 2026-09-14, and golangci-lint stayed at v2.5.0 until it broke on the Go 1.26 bump in #847 (fixed by hand in #852).After: both pins live outside the workflows, so they move again with no token or app key to manage.
tools/golangci-lint, and Dependabot'sgomodupdate keeps it current, so its pull requests run CI straight away. Atools.goblank import keeps the requirement direct, because Dependabot skips// indirectrequirements and atooldirective alone is recorded as indirect. The module stays apart from/caddyso golangci-lint's dependencies stay out of the server's build. The job reads the version from thatgo.mod, the same way the biome job reads.biome.json. Its updatecli manifest is removed.rvben/rumdlaction, with its version moved to.tool-versions, which the job reads. No Python or npm is brought in for it. Its updatecli pull requests still need a close and reopen to run CI..typos.tomlignores Go pseudo-version hashes, which the newgo.modis full of, and.dockerignoreleavestoolsand.tool-versionsout of the image.How: checked locally that
go tool golangci-lint versionreports 2.14.0, that the version steps' awk reads both pins (and bothrequireforms for golangci-lint), and that yamllint, typos and zizmor are clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01MxoPoPfm7NKhbhskvX5oR7