Skip to content

feat(agent): include accumulated text in OnTextEnd callback - #359

Open
gdemoni wants to merge 1 commit into
charmbracelet:mainfrom
gdemoni:feat/on-text-end-content
Open

gdemoni wants to merge 1 commit into
charmbracelet:mainfrom
gdemoni:feat/on-text-end-content

Conversation

@gdemoni

@gdemoni gdemoni commented Sep 11, 2026

Copy link
Copy Markdown

Summary

  • pass the fully accumulated text to OnTextEndFunc
  • update the callback signature to func(id, text string) error
  • add regression coverage for concatenated deltas and interleaved text IDs

This follows the approach proposed in #240, with additional regression coverage.

Compatibility

This changes the public OnTextEndFunc signature. Existing callbacks need to accept the new text parameter.

Testing

  • go test ./... -count=1 -timeout=30m
  • golangci-lint run

Closes #239

@gdemoni gdemoni closed this Sep 11, 2026
@gdemoni gdemoni reopened this Sep 11, 2026
@gdemoni

gdemoni commented Sep 11, 2026

Copy link
Copy Markdown
Author

Hi maintainers! @andreynering
It looks like the workflows for this PR are awaiting approval. When someone please approve them when convenient so the required checks can run? Thank you!

@gdemoni

gdemoni commented Sep 11, 2026

Copy link
Copy Markdown
Author

@andreynering
Please review my changes. If they don't introduce any new issues and effectively improve the project's bugs, please merge them. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include accumulated text in OnTextEnd callback

1 participant