Some comments updated + more tests#349
Merged
Merged
Conversation
|
armando-rodriguez-cko
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request standardizes the documentation for property constraints across multiple entity classes by replacing inconsistent constraint descriptions (like
<= 256 charactersor>= 0) with a uniform format (max 256 characters,min 0, etc.). Additionally, it introduces new unit tests to ensure correct serialization of ACH instrument details and issuing dispute requests.Key changes include:
Documentation consistency improvements:
max N characters,min N, andmax N, instead of mixed inequality symbols. This affects fields for string length, numeric ranges, and other constraints in classes likeDelegatedPaymentBillingAddress,CardholderRequest,Order,AmountAllocationCommission,PaymentSetupBillingDescriptor,PaymentSetupRequest, and various dispute and card request classes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Testing improvements:
InstrumentDetailsAchSerializationTest.phpto verify round-trip serialization and correct Swagger value output for ACH instrument account types.DisputeRequestsSerializationTest.phpto test serialization of dispute request objects, including fraud details and evidence, and to ensure fraud type values map exactly to Swagger definitions.