Skip to content

Some comments updated + more tests#349

Merged
david-ruiz-cko merged 1 commit into
masterfrom
feature/updateTests
Jul 3, 2026
Merged

Some comments updated + more tests#349
david-ruiz-cko merged 1 commit into
masterfrom
feature/updateTests

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This pull request standardizes the documentation for property constraints across multiple entity classes by replacing inconsistent constraint descriptions (like <= 256 characters or >= 0) with a uniform format (max 256 characters, min 0, etc.). Additionally, it introduces new unit tests to ensure correct serialization of ACH instrument details and issuing dispute requests.

Key changes include:

Documentation consistency improvements:

  • Updated property constraint comments throughout entity classes to use a consistent format, such as max N characters, min N, and max N, instead of mixed inequality symbols. This affects fields for string length, numeric ranges, and other constraints in classes like DelegatedPaymentBillingAddress, CardholderRequest, Order, AmountAllocationCommission, PaymentSetupBillingDescriptor, PaymentSetupRequest, and various dispute and card request classes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]

Testing improvements:

  • Added InstrumentDetailsAchSerializationTest.php to verify round-trip serialization and correct Swagger value output for ACH instrument account types.
  • Added DisputeRequestsSerializationTest.php to test serialization of dispute request objects, including fraud details and evidence, and to ensure fraud type values map exactly to Swagger definitions.

@david-ruiz-cko david-ruiz-cko requested a review from a team July 3, 2026 07:52
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@david-ruiz-cko david-ruiz-cko merged commit 6c824af into master Jul 3, 2026
4 checks passed
@david-ruiz-cko david-ruiz-cko deleted the feature/updateTests branch July 3, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants