Fix Animated Armour food handling and armoury navigation#482
Open
runsonmypc wants to merge 1 commit into
Open
Conversation
1fcc64a to
35b6258
Compare
- Raise eat threshold from ~30% to ~60% HP (Gaussian-randomized) so the bot eats sooner and survives longer between kills. - Never bank mid-kill: only restock food before animating the next suit, when fewer than two food remain. Prevents losing the suit to a bank trip in the middle of a fight. - Add an emergency mid-fight bank as a last resort only (food empty AND HP <= ~20%) to avoid dying outright. - Rework armoury navigation: walk with a distance tolerance instead of an exact tile (the slow, re-pathing invocation), with an explicit door-open fallback (IDs 24309/24306) if the walker stalls on the wrong side. - Guard armour-stand targeting on arrival distance and null-guard getWorldLocation() so we re-walk instead of failing the lookup. - Eat opportunistically during the animate delay, one tick after the animate click, when it won't overheal (missing HP >= the food's heal). - Handle InterruptedException in the loop: restore the flag and exit quietly instead of logging a misleading ERROR on stop/restart. - Adopt the queryable cache API (Rs2TileObjectModel.click()) for the armour stand; bump plugin version 1.0.1 -> 1.0.2.
35b6258 to
3e3f051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes food handling and armoury navigation in the Animated Armour plugin.
Eating
Banking — no more lost suits
Armoury navigation
walkTo(stand, 4)) instead of demanding the exact tile, which was the slow, re-pathing invocation.24309/24306, from the shortest-path transport data) if the walker stalls on the wrong side of the armoury door.getWorldLocation().Housekeeping
1.0.1→1.0.2.main; adopts the new queryable cache API (Rs2TileObjectModel.click()) for the armour stand, consistent with the upstream combat-plugin migration.Testing
./gradlew build -PpluginList=AnimatedArmourPlugin→BUILD SUCCESSFUL(plugin compiles,AnimatedArmourPlugin-1.0.2.jarpackaged, tests pass).🤖 Generated with Claude Code