chore(ui,shared): Remove unused OAuthConsent props#8352
chore(ui,shared): Remove unused OAuthConsent props#8352wobsoriano wants to merge 7 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 89fb61e The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Remove the accounts portal callback path (hasContextCallbacks) and all deprecated props (scopes, oauthApplicationName, onAllow/onDeny, redirectUrl as a pre-fetched value) now that the accounts portal renders OAuthConsent via URL params without pre-fetched data or JS callbacks. Add redirectUrl as an overridable prop alongside oauthClientId and scope, so callers embedding the component without URL params can supply it directly.
a84bf67 to
7a3fd4b
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR removes deprecated OAuth consent properties and corresponding context payload fields, updates JSDoc for Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Detailed analysisFiles modified
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
Now that we've implemented OAuthConsent component use in AP (https://github.com/clerk/accounts/pull/1418), we can safely remove the legacy callback path that was built to support the old AP integration.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change