Skip to content

fix: output version preview alias URL and id - #385

Open
sidvishnoi wants to merge 5 commits into
cloudflare:mainfrom
sidvishnoi:version-alias
Open

sidvishnoi wants to merge 5 commits into
cloudflare:mainfrom
sidvishnoi:version-alias

Conversation

@sidvishnoi

Copy link
Copy Markdown

Closes #384

Comment thread src/commandOutputParsing.ts
@therajumandapati

Copy link
Copy Markdown

@Maximo-Guk any chance you can review and approve this PR?

@sidvishnoi sidvishnoi changed the title fix: make version preview alias URL available in outputs fix: output version preview alias URL and id Sep 11, 2025
@kpyszkowski

Copy link
Copy Markdown

@sidvishnoi Thank you for addressing it. Appreciate it 🙇🏼

@ivoilic

ivoilic commented Nov 13, 2025

Copy link
Copy Markdown

@therajumandapati @Maximo-Guk this seems like an easy win with no breaking changes, would you please approve and merge? 🙏

@dario-piotrowicz

Copy link
Copy Markdown
Member

@sidvishnoi, thanks for the PR! and so sorry that it's not been reviewed in ages, I've just pushed a couple of commit to the branch, I hope you don't mind 🙏

Let's see to land this! 😄

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😄

@jamestalmage

Copy link
Copy Markdown

@sidvishnoi - you should update action.yml so the new outputs are documented... I've done so here: jamestalmage/wrangler-action@b751265

Co-authored-by: James Talmage <james@talmage.io>
@sidvishnoi

Copy link
Copy Markdown
Author

@dario-piotrowicz When can we expect a release with this?

@sidvishnoi

Copy link
Copy Markdown
Author

@dario-piotrowicz Can we have this released?

@sidvishnoi

Copy link
Copy Markdown
Author

I believe at this point, using wrangler CLI directly is a better option.

It's been 10months since this little PR was opened, which clearly shows this GitHub Action isn't a priority. And it's not just Cloudflare, but I've seen GitHub's official actions having large backlog as well (even with all the AI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version aliased preview URL is not passed to outputs

7 participants