Auto Tabbing - #9
Open
Brian0255 wants to merge 3 commits into
Open
Conversation
…a slight capiatlization fix on SotSG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code adds auto tabbing functionality for #8, based on this pending AP World code being added: cjmang/Archipelago#58
I tried to follow convention on other Data Storage keys you have set up, but if you would like anything changed about this implementation, please let me know
Most games use a single map ID for this sort of thing, but the entrance is also needed for GSTLA, so I ended up just sending a dict over from the AP World with the map and entrance to avoid weird desyncing (like if both get updated and the entrance finishes sending first, you get weird behavior in more complex dungeons)
Also, I'm not sure if you would potentially want to add a toggle button for the auto tabbing? It is a common request from users in other Poptracker packs from what I've noticed