Skip to content

fix: icon-only split-trigger inline padding to space-static-xs in one… - #4980

Merged
ywyyu17 merged 4 commits into
mainfrom
dev-v3-ywy
Sep 10, 2026
Merged

fix: icon-only split-trigger inline padding to space-static-xs in one…#4980
ywyyu17 merged 4 commits into
mainfrom
dev-v3-ywy

Conversation

@ywyyu17

@ywyyu17 ywyyu17 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

…-theme

Description

Adds a one-theme-only override for the icon-only trigger button in the button-dropdown split trigger, setting its left/right padding to the$space-static-xs token (8px).

How has this been tested?

  • Unit test
  • Screenshot test
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.67%. Comparing base (72e7e10) to head (340cdb2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4980   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files         960      960           
  Lines       31376    31376           
  Branches    11598    11597    -1     
=======================================
  Hits        30645    30645           
- Misses        685      724   +39     
+ Partials       46        7   -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywyyu17
ywyyu17 marked this pull request as ready for review September 9, 2026 09:24
@ywyyu17
ywyyu17 requested a review from a team as a code owner September 9, 2026 09:24
@ywyyu17
ywyyu17 requested review from jperals and removed request for a team September 9, 2026 09:24
padding-inline-start: calc(#{awsui.$space-s} - #{$dropdown-trigger-icon-offset});
}

@include theming.one-theme-only {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the same value to be used for the button component, here?

If so, it might be better to define a custom value for the spaceButtonIconOnlyHorizontal in the One Theme style dictionary.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @jperals! These aren't the same value. After discussing with @at-susie, we
agree spaceButtonIconOnlyHorizontal is the better choice and will keep it at 6px, This change is intentionally scoped to the button-dropdown main action only, with no impact on other components.

@ywyyu17
ywyyu17 added this pull request to the merge queue Sep 10, 2026
Merged via the queue into main with commit fb8efdc Sep 10, 2026
102 of 103 checks passed
@ywyyu17
ywyyu17 deleted the dev-v3-ywy branch September 10, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants