fix: icon-only split-trigger inline padding to space-static-xs in one… - #4980
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4980 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 960 960
Lines 31376 31376
Branches 11598 11597 -1
=======================================
Hits 30645 30645
- Misses 685 724 +39
+ Partials 46 7 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ywyyu17
temporarily deployed
to
allure-report
September 9, 2026 09:35 — with
GitHub Actions
Inactive
jperals
reviewed
Sep 9, 2026
| padding-inline-start: calc(#{awsui.$space-s} - #{$dropdown-trigger-icon-offset}); | ||
| } | ||
|
|
||
| @include theming.one-theme-only { |
Member
There was a problem hiding this comment.
Is the same value to be used for the button component, here?
If so, it might be better to define a custom value for the spaceButtonIconOnlyHorizontal in the One Theme style dictionary.
Contributor
Author
There was a problem hiding this comment.
at-susie
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-theme
Description
Adds a one-theme-only override for the icon-only trigger button in the button-dropdown split trigger, setting its left/right padding to the
$space-static-xstoken (8px).How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.