Skip to content

fix: avoid recording a duplicate price_history row on every scheduled check #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Osamaali313 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid recording a duplicate price_history row on every scheduled check #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions backend/src/services/scheduler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,11 @@ async function checkPrices(): Promise<void> {
// Get the latest recorded price to compare
const latestPrice = await priceHistoryQueries.getLatest(product.id);

// Only record if price has changed or it's the first entry
if (!latestPrice || latestPrice.price !== scrapedData.price.price) {
// Only record if price has changed or it's the first entry.
// latestPrice.price comes back from pg as a string (DECIMAL), while
// scrapedData.price.price is a number, so a raw !== is always true;
// coerce first (as the notification checks below already do).
if (!latestPrice || parseFloat(String(latestPrice.price)) !== scrapedData.price.price) {
Comment on lines +108 to +112
// Check for price drop notification before recording
if (latestPrice && product.price_drop_threshold) {
const oldPrice = parseFloat(String(latestPrice.price));
Expand Down