Skip to content

SSlaunch - Thrown movement scheduler - #12754

Closed
fira wants to merge 2 commits into
cmss13-devs:masterfrom
fira:sslaunch
Closed

SSlaunch - Thrown movement scheduler#12754
fira wants to merge 2 commits into
cmss13-devs:masterfrom
fira:sslaunch

Conversation

@fira

@fira fira commented Jul 28, 2026

Copy link
Copy Markdown
Member

About the pull request

Implement SSlaunch, a subsystem that runs throwing operations, in place of the current loop-sleep.

Explain why it's good for the game

By being scheduled bare without a SS, current throws especially with our bad explosions situation are prone to causing overtime. This is because they'll queue many movements at once. By scheduling them on a SS, we can ensure they do not take too much tick runtime and limit stuttering of the game.

Testing Photographs and Procedure

Only did basic testing, this will have to be tested more thoroughly and/or live

Changelog

🆑
code: Rewrote backend for the movement of thrown items. Some differences in throwing speed may be expected.
/:cl:

@fira fira added Performance the game sucks and this makes it suck less Needs Testing Need to test it on the guinea pigs (production server) labels Jul 28, 2026
@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 28, 2026
@cmss13-ci cmss13-ci Bot added Code Improvement Make the code longer size/L Denotes a PR that changes 200-799 lines, ignoring generated files. labels Jul 28, 2026
@cm13-github

cm13-github commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Test merge deployment history:

Test Merge Deployed @ 07/29/2026 11:42:31 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0078763
Pull Request: c675b9e
Server: 1f5a9b9

Test Merge Removed @ 07/29/2026 12:44:11 +00:00:
Server Instance

CM13 Live

@fira

fira commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

There are apparently noticeable differences with high speed throws, in particular xeno pounce. That needs to be addressed before testing again.

@fira
fira marked this pull request as draft July 29, 2026 12:48
@fira

fira commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

More importantly i completely forgot to adjust the throw_atom usage in Xeno Ability code (prae hooking, warrior lunge in particular) to account for the fact throw_atom returns immediately. Soooooooooooooo........................................ Bad time.

@fira fira added Do Not Merge If you merge this PR, I will annihilate you Do Not Тestmerge I will find you and I will testmerge you into the ground if you even think about testmerging this. labels Jul 29, 2026
@cmss13-ci

cmss13-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Aug 6, 2026
@cmss13-ci cmss13-ci Bot closed this Aug 14, 2026
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Closed in Review Backlog Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Improvement Make the code longer Do Not Тestmerge I will find you and I will testmerge you into the ground if you even think about testmerging this. Do Not Merge If you merge this PR, I will annihilate you Needs Testing Need to test it on the guinea pigs (production server) Performance the game sucks and this makes it suck less size/L Denotes a PR that changes 200-799 lines, ignoring generated files. Stale beg a maintainer to review your PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants