Tank Desant: Full Vehicle Overhaul

code/__DEFINES/client_prefs.dm

@@ -71,6 +71,21 @@
 // NOTE: Don't add flags past 1<<23, it'll break things due to BYOND limitations.
 //=================================================
 
+//toggles_vehicle bits from /datum/preferences
+//=================================================
+///Vehicle picks its own gear automatically instead of the driver shifting manually.
+#define VEHICLE_SIMPLE_TRANSMISSION (1<<0)
+///Vehicle controls use legacy WASD movement instead of tank-relative gas/brake/turn.
+#define VEHICLE_SIMPLE_CONTROLS (1<<1)
+///Vehicle acceleration uses keypress-driven momentum instead of the continuous cruise loop
+#define VEHICLE_SIMPLE_ACCELERATION (1<<2)
+///Driver HUD shows speed/acceleration in mph instead of the default km/h
+#define VEHICLE_UNITS_MPH (1<<3)
+
+///Default toggles_vehicle value.
+#define TOGGLES_VEHICLE_DEFAULT 0
+//=================================================
+
 #define JOB_SLOT_RANDOMISED_SLOT -1
 #define JOB_SLOT_CURRENT_SLOT 0
 #define JOB_SLOT_RANDOMISED_TEXT "Randomise name and appearance"

code/__DEFINES/conflict.dm

@@ -34,7 +34,7 @@
 /// Whether or not the bullet hits the target that was clicked or if it keeps travelling
 #define AMMO_HITS_TARGET_TURF (1<<17)
 #define AMMO_ALWAYS_FF (1<<18)
-//                              (1<<19) unused, previously was AMMO_HOMING
+#define AMMO_PASSES_OVER_VEHICLES (1<<19)
 /// Can't be deflected
 #define AMMO_NO_DEFLECT (1<<20)
 ///Can only hit people with criminal status
@@ -209,6 +209,16 @@
 #define ANTISTRUCT_DMG_MULT_WALL 2.5
 #define ANTISTRUCT_DMG_MULT_TANK 1.5
 
+/// Acid spits and acid shotgun were too weak against tanks, so multiply damage and wound chance.
+#define ACID_SPIT_TANK_DAMAGE_MULT 6
+#define ACID_SHOTGUN_TANK_DAMAGE_MULT 6
+#define ACID_SHOTGUN_TANK_WOUND_CHANCE_MULT 6
+#define ACID_SPIT_TANK_WOUND_CHANCE_MULT 6
+/// Another acid shotgun tweak to make it less shit against vehicles.
+#define ACID_SHOTGUN_TANK_EFFECTIVE_PENETRATION 10
+/// Multiplies bone chips' wound chances. They still deal very little damage.
+#define BONE_CHIPS_TANK_WOUND_CHANCE_MULT 2
+
 // human armor
 #define CLOTHING_ARMOR_NONE 0
 #define CLOTHING_ARMOR_VERYLOW 5

code/__DEFINES/dcs/signals/atom/mob/signals_mob.dm

@@ -1,5 +1,7 @@
 ///from base of mob/set_stat(): (new_stat, old_stat)
 #define COMSIG_MOB_STATCHANGE "mob_statchange"
+/// Sent when the player toggles a vehicle preference.
+#define COMSIG_MOB_VEHICLE_PREFS_CHANGED "mob_vehicle_prefs_changed"
 /// From /obj/structure/machinery/door/airlock/proc/take_damage
 #define COMSIG_MOB_DESTROY_AIRLOCK "mob_destroy_airlock"
 
@@ -143,6 +145,7 @@
 #define COMSIG_MOB_MOUSEDOWN "mob_mousedown"					//from /client/MouseDown(): (atom/object, turf/location, control, params)
 #define COMSIG_MOB_MOUSEUP "mob_mouseup"						//from /client/MouseUp(): (atom/object, turf/location, control, params)
 #define COMSIG_MOB_MOUSEDRAG "mob_mousedrag"				//from /client/MouseDrag(): (atom/src_object, atom/over_object, turf/src_location, turf/over_location, src_control, over_control, params)
+#define COMSIG_MOB_MOUSEMOVE "mob_mousemove"				//from /client/MouseMove(): (atom/object, turf/location, control, params)
 	#define COMSIG_MOB_CLICK_CANCELED (1<<0)
 	#define COMSIG_MOB_CLICK_HANDLED (1<<1)
 

code/__DEFINES/dcs/signals/atom/signals_projectile.dm

@@ -29,6 +29,8 @@
 #define COMSIG_BULLET_PRE_HANDLE_TURF "bullet_pre_handle_turf"
 	#define COMPONENT_BULLET_PASS_THROUGH (1<<0)
 #define COMSIG_BULLET_TERMINAL "bullet_terminal"
+/// From /obj/projectile/fly(), every tick of flight (unlike COMSIG_BULLET_TERMINAL, which only fires once, right before impact): ()
+#define COMSIG_BULLET_STEP "bullet_step"
 
 /// Called when a bullet hits a living mob on a sprite click (original target is final target)
 #define COMSIG_BULLET_DIRECT_HIT "bullet_direct_hit"

code/__DEFINES/keybinding.dm

@@ -236,6 +236,11 @@
 #define COMSIG_KB_VEHICLE_CHANGE_SELECTED_WEAPON "keybinding_change_selected_weapon"
 #define COMSIG_KB_VEHICLE_ACTIVATE_HORN "keybinding_activate_horn"
 #define COMSIG_KB_VEHICLE_RELOAD_WEAPON "keybinding_reload_weapon"
+#define COMSIG_KB_VEHICLE_TOGGLE_HARDPOINT_FIRE_MODE "keybinding_vehicle_toggle_hardpoint_fire_mode"
+#define COMSIG_KB_VEHICLE_SHIFT_GEAR_UP "keybinding_vehicle_shift_gear_up"
+#define COMSIG_KB_VEHICLE_SHIFT_GEAR_DOWN "keybinding_vehicle_shift_gear_down"
+#define COMSIG_KB_VEHICLE_TOGGLE_CRUISE_CONTROL "keybinding_vehicle_toggle_cruise_control"
+#define COMSIG_KB_VEHICLE_TOGGLE_TURRET_SAFETY "keybinding_vehicle_toggle_turret_safety"
 
 #define CATEGORY_CLIENT "CLIENT"
 #define CATEGORY_EMOTE "EMOTE"
@@ -247,7 +252,7 @@
 #define CATEGORY_HUMAN_INVENTORY "HUMAN INVENTORY"
 #define CATEGORY_ROBOT "ROBOT"
 #define CATEGORY_YAUTJA "YAUTJA"
-#define CATEGORY_VEHICLE "Vehicles"
+#define CATEGORY_VEHICLE "VEHICLE"
 #define CATEGORY_MISC "MISC"
 #define CATEGORY_MOVEMENT "MOVEMENT"
 #define CATEGORY_COMMUNICATION "COMMUNICATION"

code/__DEFINES/layers.dm

@@ -132,8 +132,21 @@
 #define FACEHUGGER_LAYER 4.13
 /// For Signs above everything but below weather
 #define BILLBOARD_LAYER 4.13
+
+/// For objs atop a tank
+#define TANK_RIDER_OBJ_LAYER 4.505
+/// Mostly for bodybags atop a tank
+#define TANK_RIDER_ABOVE_OBJ_LAYER 4.506
+/// For mobs riding atop a tank
+#define TANK_BELOW_RIDER_LAYER 4.508
+#define TANK_LYING_RIDER_LAYER 4.509
+#define TANK_RIDER_LAYER 4.51
+#define TANK_ABOVE_RIDER_LAYER 4.515
+/// For a barricade currently covered by a vehicle on the same tile.
+#define VEHICLE_COVERED_BARRICADE_LAYER 4.52
+
 /// For WEATHER
-#define WEATHER_LAYER 4.14
+#define WEATHER_LAYER 5
 
 //#define FLY_LAYER 5
 

code/__DEFINES/objects.dm

@@ -172,6 +172,8 @@ GLOBAL_LIST_INIT(RESTRICTED_CAMERA_NETWORKS, list( //Those networks can only be
 
 #define FLAME_REAGENT_USE_AMOUNT 1
 
+#define FLAME_MOUNT_AUTO "flame_mount_auto"
+
 #define CLEANABLE_SPLATTER "splatter" // Vomit, oil
 #define CLEANABLE_BLOOD "blood"
 #define CLEANABLE_BLOOD_SPLATTER "blood splatter"