Skip to content

Possible fix for bloody feet flaky test - #12769

Merged
Git-Nivrak merged 5 commits into
cmss13-devs:masterfrom
Drulikar:attempt_to_fix_flaky_test
Aug 1, 2026
Merged

Possible fix for bloody feet flaky test#12769
Git-Nivrak merged 5 commits into
cmss13-devs:masterfrom
Drulikar:attempt_to_fix_flaky_test

Conversation

@Drulikar

@Drulikar Drulikar commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

About the pull request

This PR does a few things:

  • The clear_blood timer now hands a weakref to the mob instead of a hardref (I think normally things would handle a hardref in a timer because of the src of the timer getting deleted, but I guess elements don't get deleted soo)
  • Adds a conscious check when a human is crossing blood and moving
  • Variable cleanup

Explain why it's good for the game

Should fix #12722 and should fix #12770 or we'll see it come up again.

REF SEARCH Found /mob/living/carbon/human [0x300008b] in list Datums -> /datum/callback [0x210310a4] (obj: /datum/element/bloody_feet proc: clear_blood args: ["the unknown"] -> arguments (list).

Testing Photographs and Procedure

Screenshots & Videos

Murder
image

Changelog

🆑 Drathek
fix: You now need to be conscious for bloody footprints to apply
code: Cleaned up code regarding bloody footprints and hopefully eliminated the cause of flaky tests
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 29, 2026
@cmss13-ci cmss13-ci Bot added Fix Fix one bug, make ten more size/S Denotes a PR that changes 19-49 lines, ignoring generated files. labels Jul 29, 2026
Comment thread code/datums/elements/bloody_feet.dm Outdated
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Changes Requested in Review Backlog Jul 30, 2026
@cmss13-ci cmss13-ci Bot added size/M Denotes a PR that changes 50-199 lines, ignoring generated files. and removed size/S Denotes a PR that changes 19-49 lines, ignoring generated files. labels Jul 30, 2026
Comment thread code/datums/elements/bloody_feet.dm
@cmss13-ci cmss13-ci Bot added the Code Improvement Make the code longer label Jul 31, 2026
@Git-Nivrak
Git-Nivrak added this pull request to the merge queue Aug 1, 2026
Merged via the queue into cmss13-devs:master with commit 8425d27 Aug 1, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Changes Requested to Merged in Review Backlog Aug 1, 2026
cmss13-ci Bot added a commit that referenced this pull request Aug 1, 2026
@Drulikar
Drulikar deleted the attempt_to_fix_flaky_test branch August 1, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Improvement Make the code longer Fix Fix one bug, make ten more size/M Denotes a PR that changes 50-199 lines, ignoring generated files.

Projects

Status: Merged

3 participants