Skip to content

Add Kotlin language#59

Open
kiy4h wants to merge 1 commit into
coala:masterfrom
kiy4h:add-kotlin
Open

Add Kotlin language#59
kiy4h wants to merge 1 commit into
coala:masterfrom
kiy4h:add-kotlin

Conversation

@kiy4h

@kiy4h kiy4h commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread data/Language/Kotlin.yaml Outdated
Comment thread data/Language/Kotlin.yaml Outdated
@kiy4h
kiy4h force-pushed the add-kotlin branch 2 times, most recently from 53da83a to 541db7d Compare November 23, 2018 02:28
Comment thread data/Language/Kotlin.yaml

@jayvdb jayvdb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many of these datatypes duplicate existing datatypes already defined.

@siddhpant siddhpant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datatypes already exist. Please don't make duplicates.

Please rebase the branch to remove duplicates residing in your branch before your changes too. #84 has merged some datatypes (actually all you need) in their specific file.

@@ -0,0 +1,4 @@
keyword: byte

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use byte.yaml

@@ -0,0 +1,4 @@
keyword: int

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use int.yaml

@@ -0,0 +1,4 @@
keyword: long

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use long2E63.yaml

@@ -0,0 +1,4 @@
keyword: short

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use short.yaml

@@ -0,0 +1,5 @@
type: string

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use c_char.yaml.

@@ -0,0 +1,4 @@
keyword: double

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use double_c.yaml

@@ -0,0 +1,4 @@
keyword: float

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use float_c.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants