V1.3.0/service update#16
Conversation
Greptile SummaryThis PR describes itself as a "v1.2.8 service update focused on package dependencies," but the actual scope is a v1.3.0 feature release: four Codebelt/Cuemon packages are bumped, new
Confidence Score: 5/5Safe to merge — all code changes are additive, well-tested, and the refactoring in BenchmarkWorkspaceOptions preserves the original behaviour exactly. The changes add new async entry points with the same host-builder logic already used by the sync paths, extract a private method without altering observable behaviour, expand test coverage substantially, and harden the CI pipeline with a quality-gate aggregator. No functional regressions were identified. CHANGELOG.md and both PackageReleaseNotes.txt files record version 1.3.0 while the PR title and description reference v1.2.8 — worth confirming the version label before tagging the release. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["BenchmarkProgram.Run(args, setup)"] --> B["Run(args, null, setup)"]
B --> C["Run<BenchmarkWorkspace>(args, svcConf, setup)"]
C --> D["BuildHost<TWorkspace>(args, svcConf, setup)"]
E["BenchmarkProgram.RunAsync(args, setup)"] --> F["RunAsync(args, null, setup)"]
F --> G["RunAsync<BenchmarkWorkspace>(args, svcConf, setup)"]
H["BenchmarkProgram.RunAsync<TWorkspace>(args, setup)"] --> I["RunAsync<TWorkspace>(args, null, setup)"]
I --> G
G --> D
D --> J["CreateHostBuilder(args)"]
J --> K["Configure Services"]
K --> L["builder.Build() → IHost"]
L --> M{Sync or Async?}
M -->|Run| N["host.Run()"]
M -->|RunAsync| O["await host.RunAsync()"]
N --> P["ExecuteBenchmarksAsync"]
O --> P
P --> Q{context.Args empty?}
Q -->|Yes| R["BenchmarkRunner.Run per assembly"]
Q -->|No| S["BenchmarkSwitcher.FromAssemblies"]
R --> T["workspace.PostProcessArtifacts()"]
S --> T
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
CHANGELOG.md:363
**PR title/description version mismatch**
The PR is titled "V1.2.8/service update" and the description states this is a "service update that focuses on package dependencies" with "CHANGELOG.md entry added for v1.2.8." In reality the changelog, both `PackageReleaseNotes.txt` files, and the solution all record version **1.3.0** with new public APIs (`RunAsync` overloads), new test projects, and CI changes. If automated tooling generated the PR metadata from a stale template, this entry should be corrected before the release is tagged to avoid confusion in release tracking.
Reviews (2): Last reviewed commit: "🎨 remove unused line from benchmark fil..." | Re-trigger Greptile |
| <PackageVersion Include="xunit.v3.runner.console" Version="3.2.2" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" /> | ||
| </ItemGroup> | ||
| </Project> |
There was a problem hiding this comment.
Missing trailing newline at end of file
The file no longer ends with a newline character. Many editors, linters, and POSIX-compliant tools expect text files to terminate with a newline; its absence can produce noisy diffs and warnings from tools like editorconfig or CI lint checks.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Directory.Packages.props
Line: 19
Comment:
**Missing trailing newline at end of file**
The file no longer ends with a newline character. Many editors, linters, and POSIX-compliant tools expect text files to terminate with a newline; its absence can produce noisy diffs and warnings from tools like `editorconfig` or CI lint checks.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Sadly, this is automatically changed by Visual Studio 2026 when updating the dependencies. I prefer the extra linebreak, but IDE has its own life.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
===========================================
+ Coverage 66.95% 91.25% +24.30%
===========================================
Files 6 7 +1
Lines 345 389 +44
Branches 42 44 +2
===========================================
+ Hits 231 355 +124
+ Misses 114 34 -80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Establish .bot/ folder for local-only AI agent ideation, PRDs, design proposals, and agentic loop state. Add .gitignore rules to exclude .bot/* with exception for .bot/README.md.
Introduce AGENTS.md with comprehensive guidance for AI agents working in this repository, covering project overview, coding standards, project structure, test conventions, build & CI practices, and policies for local-only .bot/ folder management.
Add section 10 to copilot-instructions.md establishing that ExcludeFromCodeCoverage attribute must not be used on any code. Instead, unmeasurable code paths should be refactored or removed. Includes rationale and alternative approaches for common scenarios.
Update Microsoft.NET.Test.Sdk from 18.5.1 to 18.6.0 in centralized package version management.
Extract ParseTargetFrameworkMoniker in BenchmarkWorkspaceOptions and BuildHost in BenchmarkProgram to improve unit testability. Isolates framework moniker parsing and host initialization logic into separate, testable methods rather than embedded within larger functions.
Significantly expand unit test coverage for BenchmarkWorkspace, BenchmarkWorkspaceOptions, BenchmarkProgram, and ServiceCollectionExtensions. Add new functional test projects for Console and core assemblies (Codebelt.Extensions.BenchmarkDotNet.Console.FunctionalTests and Codebelt.Extensions.BenchmarkDotNet.FunctionalTests) to validate end-to-end behavior. Update solution file to include new test projects.
Refresh API reference documentation for the Codebelt.Extensions.BenchmarkDotNet.Console namespace to reflect new async methods and refactored helper methods in the BenchmarkProgram class.
Update PackageReleaseNotes.txt files for both Codebelt.Extensions.BenchmarkDotNet and Codebelt.Extensions.BenchmarkDotNet.Console packages with v1.3.0 release highlights including async support additions, code refactoring, and expanded test coverage improvements.
Record v1.3.0 minor release in Keep a Changelog format. Highlights code organization improvements, async support additions, test coverage expansion, macOS CI/CD support, and comprehensive agent guidance documentation. Reflects transition from v1.2.8 service update to v1.3.0 feature release.
Clean up BenchmarkProgramBenchmark.cs to remove a trailing unused line.
This is a service update that focuses on package dependencies.
Automated changes:
Note: Third-party packages (Microsoft.Extensions.*, BenchmarkDotNet, etc.) are not auto-updated.
Use Dependabot or manual updates for those.
Generated by codebelt-aicia
Triggered by: xunit @ 11.1.0