✨ add macos support for test project conditions#163
Conversation
Greptile SummaryThis PR extends the MSBuild configuration to recognise macOS as a build platform and applies the same
Confidence Score: 5/5Safe to merge — the change is a two-line, well-scoped addition that mirrors the existing Linux pattern exactly. The No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MSBuild evaluates Directory.Build.props] --> B{IsTestProject?}
B -- No --> C[Source / Tooling / Benchmark project groups apply]
B -- Yes --> D{OS Detection}
D -- IsLinux == true\nOR IsMacOS == true --> E[TargetFrameworks = net10.0;net9.0]
D -- IsWindows == true --> F[TargetFrameworks = net10.0;net9.0;net48]
D -- Neither --> G[TargetFrameworks unset - inherits project default]
E --> H[Common test settings applied]
F --> H
G --> H
Reviews (1): Last reviewed commit: "✨ add macos support for test project con..." | Re-trigger Greptile |
This pull request updates the build configuration to improve platform detection and test project targeting. The main changes are the addition of a property to detect macOS and updating test project conditions to include macOS alongside Linux.
Platform detection improvements:
IsMacOSproperty inDirectory.Build.propsto detect when the build is running on macOS.Test project framework targeting:
Directory.Build.propsso that projects on both Linux and macOS use the same target frameworks (net10.0;net9.0).